Differential D11184

[lib] Compute hashes only from one keyserver
ClosedPublic
Actions

Authored by tomek on Feb 27 2024, 5:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 11:51 PM

	Unknown Object (File)
	Mon, Nov 25, 9:40 PM

	Unknown Object (File)
	Wed, Nov 13, 12:52 PM

	Unknown Object (File)
	Wed, Nov 13, 12:52 PM

	Unknown Object (File)
	Wed, Nov 13, 12:51 PM

	Unknown Object (File)
	Wed, Nov 13, 12:48 PM

	Unknown Object (File)
	Wed, Nov 13, 12:39 PM

	Unknown Object (File)
	Oct 10 2024, 11:47 AM

View All 59 Files

Subscribers

Details

Reviewers

michal
atul
inka
kamil

Commits

rCOMMacec0aca765a: [lib] Compute hashes only from one keyserver

Summary

When doing state check we should only compute hashes for entities from a keyserver performing the check.

https://linear.app/comm/issue/ENG-3915/refactor-generating-a-response-to-serverrequesttypescheck-state

Depends on D11183

Test Plan

Checked that the state sync still works - modified a thread and an entry and verified that the sync updates values properly on the client side.
Modified state selectors in entries and threads specs to return one more entity from a different keyserver and verified that the hashes were still correct (also performed the test mentioned earlier with the modified code).

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Feb 27 2024, 5:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2024, 5:59 AM

Harbormaster completed remote builds in B27200: Diff 37649.Feb 27 2024, 6:27 AM

tomek requested review of this revision.Feb 27 2024, 6:27 AM

tomek added a child revision: D11185: [lib] Check keyserver connection in request-response-handler.Feb 27 2024, 6:27 AM

michal accepted this revision.Feb 28 2024, 6:06 AM

michal added inline comments.

lib/shared/state-sync/threads-state-sync-spec.js
45 ↗	(On Diff #37649)	Nit: this isn't a threadInfo but a thread hash.

This revision is now accepted and ready to land.Feb 28 2024, 6:06 AM

Fix prop name

Harbormaster failed remote builds in B27238: Diff 37700!Feb 29 2024, 7:24 AM

Harbormaster completed remote builds in B27238: Diff 37700.Feb 29 2024, 7:32 AM

Closed by commit rCOMMacec0aca765a: [lib] Compute hashes only from one keyserver (authored by tomek). · Explain WhyFeb 29 2024, 7:42 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMacec0aca765a: [lib] Compute hashes only from one keyserver.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

socket-selectors.js

12 lines

shared/

state-sync/

entries-state-sync-spec.js

30 lines

state-sync-spec.js

6 lines

threads-state-sync-spec.js

20 lines

Diff 37700

lib/selectors/socket-selectors.js

Loading...

lib/shared/state-sync/entries-state-sync-spec.js

Loading...

lib/shared/state-sync/state-sync-spec.js

Loading...

lib/shared/state-sync/threads-state-sync-spec.js

Loading...