Page MenuHomePhabricator

[lib] Compute hashes only from one keyserver
ClosedPublic

Authored by tomek on Feb 27 2024, 5:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:52 PM
Unknown Object (File)
Wed, Nov 13, 12:52 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
Unknown Object (File)
Wed, Nov 13, 12:39 PM
Unknown Object (File)
Oct 10 2024, 11:47 AM
Unknown Object (File)
Oct 10 2024, 11:19 AM
Unknown Object (File)
Sep 16 2024, 2:00 PM
Subscribers

Details

Summary

When doing state check we should only compute hashes for entities from a keyserver performing the check.

https://linear.app/comm/issue/ENG-3915/refactor-generating-a-response-to-serverrequesttypescheck-state

Depends on D11183

Test Plan

Checked that the state sync still works - modified a thread and an entry and verified that the sync updates values properly on the client side.
Modified state selectors in entries and threads specs to return one more entity from a different keyserver and verified that the hashes were still correct (also performed the test mentioned earlier with the modified code).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Feb 27 2024, 6:27 AM
michal added inline comments.
lib/shared/state-sync/threads-state-sync-spec.js
45 ↗(On Diff #37649)

Nit: this isn't a threadInfo but a thread hash.

This revision is now accepted and ready to land.Feb 28 2024, 6:06 AM
tomek marked an inline comment as done.

Fix prop name