we need this method to implement the GetFarcasterUsers RPC
Depends on D11400
Details
Details
Registered some wallet and password users with FIDs, confirmed that their corresponding user info was returned by the db method when called with the same FIDs
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/src/database/farcaster.rs | ||
|---|---|---|
| 64–84 | this felt messy but wasn't immediately obvious to me how to write it cleaner using the traits from comm_lib | |
| services/identity/src/database/farcaster.rs | ||
|---|---|---|
| 30–33 | Wondering if BatchGetItem wouldn't fit better here. | |
| 66–82 | Maybe sth like this? Option<T> implements TryFromAttribute so you can use take_attr() - it returns None when the attribute is missing | |
Comment Actions
Requesting changes to discuss possible usage of BatchGetItem
| services/identity/src/database/farcaster.rs | ||
|---|---|---|
| 21 | Why do you need this tuple struct? I guess it's for distinguishing between proto and db types | |
| services/identity/src/database/farcaster.rs | ||
|---|---|---|
| 30–33 | Okay I realized that BatchGetItem doesn't support indexes so we have to use queries | |
| services/identity/src/database/farcaster.rs | ||
|---|---|---|
| 21 | it's so that i can implement TryFrom<AttributeMap>. I don't own the FarcasterUser type, so I have to wrap it in a type that I do own | |
| 30–33 | input could be hundreds or thousands of IDs. i called the RPC with 1000 random IDs and although it took 2.5 seconds to complete my request, it didn't fail. | |
| services/identity/src/database/farcaster.rs | ||
|---|---|---|
| 66–82 | this is a lot cleaner, thanks! | |