Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate…

Summary

Similar to D11641, but for validators.

Depends on D11641

Test Plan

Will add unit tests to this before landing/after rest of stack is up.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 12 2024, 3:42 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 12 2024, 3:42 AM

Harbormaster completed remote builds in B28182: Diff 39071.Apr 12 2024, 3:58 AM

atul requested review of this revision.Apr 12 2024, 3:58 AM

tomek accepted this revision.Apr 12 2024, 9:41 AM

tomek added inline comments.

lib/types/messages/update-relationship.js
65 ↗	(On Diff #39071)

This revision is now accepted and ready to land.Apr 12 2024, 9:41 AM

atul added a child revision: D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.Apr 12 2024, 6:47 PM

atul added a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Apr 12 2024, 7:21 PM

fix TUnion import

Harbormaster completed remote builds in B28245: Diff 39155.Apr 16 2024, 6:08 PM

atul removed a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Apr 16 2024, 7:22 PM

rebase BEFORE addressing feedback

address feedback and land

Harbormaster completed remote builds in B28276: Diff 39199.Apr 17 2024, 8:14 PM

This revision was landed with ongoing or failed builds.Apr 17 2024, 8:17 PM

Closed by commit rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate…. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate….

Harbormaster completed remote builds in B28278: Diff 39201.Apr 17 2024, 8:26 PM

[lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 39155

lib/types/messages/update-relationship.js

[lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39155

lib/types/messages/update-relationship.js

[lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`
ClosedPublic
Actions

Revision Contents
Changeset List