Page MenuHomePhabricator
Differential D11642

[lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`
ClosedPublic
Actions

Authored by atul on Apr 11 2024, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 4:16 AM
Unknown Object (File)
Mon, Feb 3, 7:28 AM
Unknown Object (File)
Thu, Jan 30, 9:10 AM
Unknown Object (File)
Tue, Jan 28, 8:24 PM
Unknown Object (File)
Tue, Jan 28, 7:32 PM
Unknown Object (File)
Tue, Jan 28, 6:14 PM
Unknown Object (File)
Tue, Jan 28, 4:50 PM
Unknown Object (File)
Tue, Jan 28, 1:42 AM
View All 79 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate…
Summary

Similar to D11641, but for validators.

Depends on D11641

Test Plan

Will add unit tests to this before landing/after rest of stack is up.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D11642 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 11 2024, 8:42 PM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 11 2024, 8:42 PM
Harbormaster completed remote builds in B28182: Diff 39071.Apr 11 2024, 8:58 PM
atul requested review of this revision.Apr 11 2024, 8:58 PM
tomek accepted this revision.Apr 12 2024, 2:41 AM
tomek added inline comments.
lib/types/messages/update-relationship.js
65 ↗(On Diff #39071)
This revision is now accepted and ready to land.Apr 12 2024, 2:41 AM
atul added a child revision: D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.Apr 12 2024, 11:47 AM
atul added a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Apr 12 2024, 12:21 PM
atul updated this revision to Diff 39155.Apr 16 2024, 10:51 AM

fix TUnion import

Harbormaster completed remote builds in B28245: Diff 39155.Apr 16 2024, 11:08 AM
atul removed a child revision: D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.Apr 16 2024, 12:22 PM
atul updated this revision to Diff 39199.Apr 17 2024, 12:58 PM

rebase BEFORE addressing feedback

atul updated this revision to Diff 39201.Apr 17 2024, 1:10 PM

address feedback and land

Harbormaster completed remote builds in B28276: Diff 39199.Apr 17 2024, 1:14 PM
This revision was landed with ongoing or failed builds.Apr 17 2024, 1:17 PM
Closed by commit rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate….
Harbormaster completed remote builds in B28278: Diff 39201.Apr 17 2024, 1:26 PM

Revision Contents
Changeset List

PathSize
lib/
types/
messages/
29 lines

Diff 39199

View Options

lib/types/messages/update-relationship.js

Loading...