Page MenuHomePhabricator
Differential D11793

[native] introduce tag farcaster button
ClosedPublic
Actions

Authored by ginsu on Apr 25 2024, 3:21 PM.
Tags
None
Referenced Files
F3699653: D11793.diff
Tue, Jan 7, 3:49 PM
Unknown Object (File)
Mon, Jan 6, 12:28 PM
Unknown Object (File)
Sun, Dec 29, 1:15 PM
Unknown Object (File)
Sun, Dec 29, 1:15 PM
Unknown Object (File)
Sun, Dec 29, 1:15 PM
Unknown Object (File)
Sun, Dec 29, 1:15 PM
Unknown Object (File)
Sun, Dec 29, 1:15 PM
Unknown Object (File)
Sun, Dec 29, 1:15 PM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ashoat
Commits
rCOMMc8d773fdac04: [native] introduce tag farcaster button
Summary

This diff introduces the button + onPress logic for tagging a farcaster channel. The onPress logic will dispatch the createOrUpdateFarcasterChannelTagAction that was introduced in previous diffs

Please note this diff will not be landed until I introduce a gate to guarantee no one can trigger this button

Depends on D11785

Test Plan

Confirmed that when I pressed the bottom I was able to call the create_or_update_farcaster_channel_tag endpoint

Also please see the demo video below to see the ui/ux button

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 25 2024, 3:21 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 25 2024, 3:21 PM
Harbormaster completed remote builds in B28489: Diff 39519.Apr 25 2024, 3:38 PM
ginsu requested review of this revision.Apr 25 2024, 3:38 PM
ashoat added a comment.Apr 25 2024, 3:46 PM

No reviewers specified

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
132

Did you forget this todo?

ginsu edited the summary of this revision. (Show Details)Apr 25 2024, 4:17 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11785: [native] introduce TagFarcasterChannelParams.
ginsu attached a referenced file: F1664658: Screen Recording 2024-04-25 at 7.13.48 PM.mov. (Show Details)
ginsu added a reviewer: ashoat.Apr 25 2024, 4:20 PM

Adding @ashoat as a blocking reviewer since there are copy changes in this diff

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
132

This was intentional, the very next diff will address this

177

This copy needs to be reviewed

ashoat resigned from this revision.Apr 25 2024, 7:17 PM

Copy looks good!

ginsu updated this revision to Diff 39585.Apr 26 2024, 12:00 PM
ginsu edited the test plan for this revision. (Show Details)

update createCreateOrUpdateActionPromise to return the response

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
132 ↗(On Diff #39585)

The very next diff will address this

ginsu added a child revision: D11809: [native] show error message for tag farcaster channel errors.Apr 26 2024, 12:11 PM
ginsu added inline comments.
native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
132 ↗(On Diff #39585)

D11809

Harbormaster completed remote builds in B28530: Diff 39585.Apr 26 2024, 12:20 PM
inka accepted this revision.Apr 30 2024, 8:30 AM
This revision is now accepted and ready to land.Apr 30 2024, 8:30 AM
ginsu updated this revision to Diff 39697.Apr 30 2024, 9:14 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 30 2024, 9:23 AM
Closed by commit rCOMMc8d773fdac04: [native] introduce tag farcaster button (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc8d773fdac04: [native] introduce tag farcaster button.
Harbormaster completed remote builds in B28603: Diff 39697.Apr 30 2024, 9:31 AM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
48 lines

Diff 39519

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...