Page MenuHomePhabricator
Differential D11923

[native] Delete unused functions
ClosedPublic
Actions

Authored by tomek on May 7 2024, 8:43 AM.
Tags
None
Referenced Files
F3305820: D11923.diff
Mon, Nov 18, 4:22 PM
Unknown Object (File)
Sun, Nov 10, 2:15 PM
Unknown Object (File)
Sun, Nov 10, 11:50 AM
Unknown Object (File)
Sun, Nov 10, 11:49 AM
Unknown Object (File)
Sun, Nov 10, 3:17 AM
Unknown Object (File)
Sun, Oct 20, 6:45 AM
Unknown Object (File)
Oct 10 2024, 10:39 PM
Unknown Object (File)
Oct 10 2024, 10:39 PM
View All 48 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
varun
Commits
rCOMM94b3621f714b: [native] Delete unused functions
Summary

All the async functions that process a single store can now be deleted - we should only use the new function which processes all the stores in a single transaction.

https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction

Depends on D11922

Test Plan

Checked if persisting drafts still works.

Diff Detail

Repository
rCOMM Comm
Branch
transactions
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 7 2024, 8:43 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 7 2024, 8:43 AM
Harbormaster completed remote builds in B28738: Diff 39896.May 7 2024, 9:00 AM
tomek requested review of this revision.May 7 2024, 9:00 AM
tomek added a child revision: D11931: [lib] Expose function that processes operations as a part of SQLite API.May 8 2024, 3:16 AM
marcin accepted this revision.May 8 2024, 3:19 AM

Checked if persisting drafts still works.

Same suggestions to test plan as for parent diff.

This revision is now accepted and ready to land.May 8 2024, 3:19 AM
tomek added a comment.May 9 2024, 4:51 AM
In D11923#341468, @marcin wrote:

Checked if persisting drafts still works.

Same suggestions to test plan as for parent diff.

Tested also messages and threads.

Closed by commit rCOMM94b3621f714b: [native] Delete unused functions (authored by tomek). · Explain WhyMay 9 2024, 5:25 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM94b3621f714b: [native] Delete unused functions.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
31 lines
68 lines
PersistentStorageUtilities/
DataStores/
50 lines
_generated/
schema/
41 lines

Diff 39896

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...