Page MenuHomePhabricator
Differential D12156

[lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach
ClosedPublic
Actions

Authored by tomek on May 21 2024, 8:49 AM.
Tags
None
Referenced Files
F3390258: D12156.diff
Fri, Nov 29, 11:01 PM
Unknown Object (File)
Tue, Nov 26, 7:34 PM
Unknown Object (File)
Tue, Nov 26, 5:41 PM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
Unknown Object (File)
Sun, Nov 10, 7:00 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 2:29 AM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
View All 61 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMMd5051a94745d: [lib] Update delete keyserver, delete thread, leave thread and set new session…
Summary

These actions override the store with a modified one - replicate the logic for the ops.

Depends on D12157

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Be on the latest diff if this stack to ensure there is no mechanism from the keyserver that would aid entry persistence. After testing each actions kill the app and reopen it to ensure that changes are correctly persisted.

  1. To test delete keyserver, delete thread, leave thread by: create community, then a chat in the community, then the entry for the chat and finally deleted the chat. Ensure that it disappeared from SQLite.
  2. To test set new session: TODO

Diff Detail

Repository
rCOMM Comm
Branch
entries
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 21 2024, 8:49 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 8:49 AM
tomek added a child revision: D12157: [native] Add a migration that moves entries to SQLite.May 21 2024, 8:56 AM
tomek removed a parent revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 21 2024, 8:56 AM
tomek added a parent revision: D12152: [lib] Schedule entry store ops processing.
tomek removed a parent revision: D12152: [lib] Schedule entry store ops processing.May 21 2024, 8:58 AM
tomek removed a child revision: D12157: [native] Add a migration that moves entries to SQLite.
tomek added a parent revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 9:34 AM
Harbormaster failed remote builds in B29121: Diff 40488!
tomek added a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:23 PM
tomek updated this revision to Diff 40510.May 21 2024, 12:43 PM

Rebase

Harbormaster completed remote builds in B29142: Diff 40510.May 21 2024, 1:07 PM
tomek requested review of this revision.May 21 2024, 1:07 PM
marcin added inline comments.May 22 2024, 3:09 AM
lib/reducers/entry-reducer.js
224–232 ↗(On Diff #40510)

Do we actually need to combine two actions? Perhaps we can establish which need deletion and use once remove_entries action?

265 ↗(On Diff #40510)

Same here.

tomek removed a parent revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 22 2024, 3:48 AM
tomek added a parent revision: D12157: [native] Add a migration that moves entries to SQLite.
tomek edited the summary of this revision. (Show Details)
tomek added inline comments.May 22 2024, 4:18 AM
lib/reducers/entry-reducer.js
224–232 ↗(On Diff #40510)

That would be more efficient but also would be more complicated. We can consider doing this though.

marcin edited the test plan for this revision. (Show Details)May 22 2024, 5:32 AM
marcin added inline comments.
lib/reducers/entry-reducer.js
207 ↗(On Diff #40510)

Tested. Works

marcin accepted this revision.May 23 2024, 5:32 AM
marcin added inline comments.
lib/reducers/entry-reducer.js
239 ↗(On Diff #40510)

Currently I am unable to test this one. I will accept this diff since all actions were tested and worked so it is unlikely that this particular action doesn't/ However before landing I will ask someone to test it by deleting latest cookie id.

This revision is now accepted and ready to land.May 23 2024, 5:32 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:07 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:20 AM
Closed by commit rCOMMd5051a94745d: [lib] Update delete keyserver, delete thread, leave thread and set new session… (authored by tomek). · Explain WhyMay 27 2024, 5:50 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMd5051a94745d: [lib] Update delete keyserver, delete thread, leave thread and set new session….

Revision Contents
Changeset List

PathSize
lib/
reducers/
48 lines

Diff 40488

View Options

lib/reducers/entry-reducer.js

Loading...