Page MenuHomePhabricator
Differential D12162

[lib] Replace merging entries with an ops approach
ClosedPublic
Actions

Authored by tomek on May 21 2024, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 12:35 PM
Unknown Object (File)
Sun, Nov 10, 6:48 AM
Unknown Object (File)
Sun, Nov 10, 2:29 AM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
Unknown Object (File)
Fri, Nov 1, 7:32 PM
Unknown Object (File)
Oct 12 2024, 7:57 PM
Unknown Object (File)
Oct 12 2024, 1:54 PM
Unknown Object (File)
Oct 4 2024, 7:35 PM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMM493a05d77625: [lib] Replace merging entries with an ops approach
Summary

Merging the entries now returns the ops which are later processed

Depends on D12156

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Be on the latest diff if this stack to ensure there is no mechanism from the keyserver that would aid entry persistence. After testing each actions kill the app and reopen it to ensure that changes are correctly persisted.

  1. To test fetchEntriesActionTypes.success: click history on a day in calendar on Web
  2. To test updateCalendarQueryActionTypes.success: create entry on web in a distant month in the past and then scrolling calendar in native to that date. Ensure that new entry appeared in the DB after scrolling close to the date.
  3. To test saveEntryActionTypes.success: edit and save entry on web.
  4. To test deleteEntryActionTypes: delete entry and check in SQLite that deleted property is marked as true and entry is not visible across app restarts.
  5. To test restoreEntryActionTypes.success: Delete and restore on web. Reopen the app between steps, and ensure that changes are persisted.
  6. To test legacyLogInActionTypes.success, legacySiweAuthActionTypes.success, keyserverAuthActionTypes.success: log in and log out and seeing that entries are in db after logging in back.
  7. To test incrementalStateSyncActionType: background mobile app, do something in calendar on web and foreground the app again.
  8. To test processUpdatesActionType, joinThreadActionTypes.success, newThreadActionTypes.success: modify entry on web and see immediate update (UI and DB) on native.
  9. To test fullStateSyncActionType by a hack: Go to socket.js  in keyserver, change condition in line 515 to be true, kill the native app, modify calendar on web an open the native app.
  10. To test processServerRequestsActionType: This actions is dispatched a short while after creating entry when it transitions from local to remote.

Diff Detail

Repository
rCOMM Comm
Branch
entries
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 21 2024, 12:23 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 12:23 PM
tomek edited parent revisions, added: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach; removed: D12157: [native] Add a migration that moves entries to SQLite.May 21 2024, 12:23 PM
tomek retitled this revision from [native] Replace merging entries with an ops approach to [lib] Replace merging entries with an ops approach.May 21 2024, 12:28 PM
tomek added a parent revision: D12157: [native] Add a migration that moves entries to SQLite.
tomek removed a parent revision: D12157: [native] Add a migration that moves entries to SQLite.May 21 2024, 12:33 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 12:40 PM
Harbormaster failed remote builds in B29131: Diff 40499!
tomek updated this revision to Diff 40511.May 21 2024, 12:44 PM
tomek added a parent revision: D12157: [native] Add a migration that moves entries to SQLite.

Rebase

tomek edited the summary of this revision. (Show Details)May 21 2024, 12:44 PM
tomek removed a parent revision: D12157: [native] Add a migration that moves entries to SQLite.
tomek added a child revision: D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.May 21 2024, 12:51 PM
Harbormaster completed remote builds in B29143: Diff 40511.May 21 2024, 1:12 PM
tomek requested review of this revision.May 21 2024, 1:12 PM
marcin added inline comments.May 22 2024, 6:49 AM
lib/reducers/entry-reducer.js
287 ↗(On Diff #40511)

Tested works. Tested by clicking history on calendar entry in Web.

313 ↗(On Diff #40511)

Tested works. Tested by creating entry on web in a distant month in the past and then scrolling calendar in native to that date. Ensure that new entry appeared in the DB after scrolling close to the date.

340 ↗(On Diff #40511)

Tested works. Tested by creating entry and ensuring that it appears in the DB immediately and has local id

407 ↗(On Diff #40511)

Tested works. Tested by editing and saving entry on web.

488 ↗(On Diff #40511)

Tested. Works. Tested by deleting entry and checking in SQLite that deleted property is marked and entry is not visible across app restarts.

537 ↗(On Diff #40511)

Tested works. Deleted and restored on web. Reopened app between steps,

552 ↗(On Diff #40511)

Tested works. Tested by logging in and logging out and seeing that entries are in db after logging in.

marcin added inline comments.May 22 2024, 7:06 AM
lib/reducers/entry-reducer.js
598 ↗(On Diff #40511)

Tested works. Tested by modifying entry on web and seeing immediate update (UI and DB) on native.

marcin added inline comments.May 22 2024, 7:26 AM
lib/reducers/entry-reducer.js
716 ↗(On Diff #40511)

Tested works. Texted by restarting the app and seeing that entries are in calendar.

marcin added inline comments.May 22 2024, 8:25 AM
lib/reducers/entry-reducer.js
626 ↗(On Diff #40511)

Tested works. Created community as user A, added user B, created entry and deleted user B. Checked that entry disappeared from B database.

marcin added inline comments.May 23 2024, 3:54 AM
lib/reducers/entry-reducer.js
574 ↗(On Diff #40511)

Tested works. Tested by backgrounding mobile app, doing something in calendar on web and foregrounding the app again.

marcin added inline comments.May 23 2024, 4:32 AM
lib/reducers/entry-reducer.js
655 ↗(On Diff #40511)

Tested works. This actions is dispatched a short while after creating entry when it transitions from local to remote.

marcin added inline comments.May 23 2024, 5:16 AM
lib/reducers/entry-reducer.js
614 ↗(On Diff #40511)

Tested works. I had to hack it. I went to socket.js in keyserver, changed condition in line 515 to be true, kill the native app, modify calendar on web an open the native app.

marcin accepted this revision.May 23 2024, 5:28 AM
This revision is now accepted and ready to land.May 23 2024, 5:28 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:31 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:34 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:38 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 8:01 AM
marcin edited the test plan for this revision. (Show Details)May 24 2024, 8:16 AM
Closed by commit rCOMM493a05d77625: [lib] Replace merging entries with an ops approach (authored by tomek). · Explain WhyMay 27 2024, 5:50 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM493a05d77625: [lib] Replace merging entries with an ops approach.

Revision Contents
Changeset List

PathSize
lib/
reducers/
215 lines

Diff 40499

View Options

lib/reducers/entry-reducer.js

Loading...