Details

Reviewers

Commits

rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`

Summary

Part of resolving the flow issues introduced (intentionally) in D12594.

IMPORTANT: This is used on client to create NEW *RawThreadInfos which is persisted representation. We want to make sure this change is landed in same release as migration so we don't end up having *RawThreadInfos with/without member permissions persisted before migration.

Depends on D12594

Test Plan

Create new threads on native/web client and ensure that ThinRawThreadInfos are created/persisted without member permissions.

NOTE: 6 remaining flow issues expected.

Diff Detail

Repository

rCOMM Comm

Branch

july26 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 27 2024, 1:19 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2024, 1:19 PM

atul edited the test plan for this revision. (Show Details)Jun 27 2024, 1:20 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 27 2024, 1:32 PM

Harbormaster failed remote builds in B29970: Diff 41769!

atul requested review of this revision.Jun 27 2024, 1:42 PM

atul added a child revision: D12598: [lib] Deprecate `decodeMinimallyEncodedRawThreadInfo`.Jun 27 2024, 1:44 PM

remove extraneous import

Harbormaster failed remote builds in B29972: Diff 41771!Jun 27 2024, 2:00 PM

ashoat accepted this revision.Jul 1 2024, 1:09 PM

This revision is now accepted and ready to land.Jul 1 2024, 1:09 PM

ashoat mentioned this in D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Jul 1 2024, 1:09 PM

resolve merge conflict

Harbormaster failed remote builds in B30230: Diff 42153!Jul 9 2024, 11:11 AM

rebase after resequence

Harbormaster failed remote builds in B30244: Diff 42178!Jul 9 2024, 2:19 PM

atul added a child revision: D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 10 2024, 2:42 PM

atul added a child revision: D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 11 2024, 1:27 PM

atul removed a child revision: D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 15 2024, 11:31 AM

rebase after landing validator fix

fix ESLint issue

atul mentioned this in D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 17 2024, 2:14 PM

atul added a child revision: D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 17 2024, 2:18 PM

Harbormaster failed remote builds in B30433: Diff 42409!Jul 17 2024, 2:22 PM

Harbormaster failed remote builds in B30434: Diff 42410!

rebase

Harbormaster completed remote builds in B30484: Diff 42486.Jul 18 2024, 12:58 PM

It's actually fine to land this as-is. If migration runs on RawThreadInfo that's already missing permissions, nothing will happen since stripPermissionsFromMemberInfo just won't really do anything: