Page MenuHomePhabricator

[lib] Deprecate `decodeMinimallyEncodedRawThreadInfo`
AcceptedPublic

Authored by atul on Thu, Jun 27, 1:44 PM.
Tags
None
Referenced Files
F2164455: D12598.diff
Mon, Jul 1, 11:35 PM
F2164207: D12598.diff
Mon, Jul 1, 10:46 PM
Unknown Object (File)
Thu, Jun 27, 3:46 PM
Unknown Object (File)
Thu, Jun 27, 3:45 PM
Unknown Object (File)
Thu, Jun 27, 3:38 PM
Subscribers

Details

Reviewers
ashoat
Summary

This function is used in 3 places:

  1. Unit tests
  2. updateRolesAndPermissions
  3. deprecatedConvertClientDBThreadInfoToRawThreadInfo

We will deprecate updateRolesAndPermissions in subsequent diff in this stack, at which point this function will only be relevant for keeping existing "legacy" migrations functional. It will not and should NOT be used for migrations going forward because there are no encoded member permissions to be decoded in future persisted *RawThreadInfo.


Depends on D12597

Test Plan

This diff is just a rename, will add flow suppression in next diff. Looked at all callsites and made sure there's nothing preventing function from being deprecated.

Diff Detail

Repository
rCOMM Comm
Branch
july26 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Thu, Jun 27, 1:45 PM

Is the idea here that we'll never need to decode the permissions on RawThreadInfo again, since we don't store the permissions on the client?

How about all the other decode* and encode* functions – should those be marked as deprecated as well?

This revision is now accepted and ready to land.Mon, Jul 1, 1:02 PM