Page MenuHomePhabricator
Differential D12661

[lib/native/web] factor out remaining shared logic + copy for thread notification settings
ClosedPublic
Actions

Authored by ginsu on Jul 3 2024, 8:44 PM.
Tags
None
Referenced Files
F2901304: D12661.diff
Sat, Oct 5, 12:26 PM
Unknown Object (File)
Wed, Sep 25, 8:51 PM
Unknown Object (File)
Wed, Sep 25, 8:50 PM
Unknown Object (File)
Thu, Sep 12, 2:23 PM
Unknown Object (File)
Tue, Sep 10, 3:24 PM
Unknown Object (File)
Tue, Sep 10, 3:05 PM
Unknown Object (File)
Tue, Sep 10, 2:02 PM
Unknown Object (File)
Tue, Sep 10, 12:36 PM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMd805cb6dbfba: [lib/native/web] factor out remaining shared logic + copy for thread…
Summary

This diff factors out more logic + copy that will be shared in the thread notifications settings across web and native

Depends on D12654

Test Plan

Confirmed that there were no regressions with the thread notications settings on web

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 3 2024, 8:44 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 3 2024, 8:44 PM
ginsu edited the summary of this revision. (Show Details)Jul 3 2024, 8:46 PM
ginsu added reviewers: ashoat, inka.
ginsu added a parent revision: D12654: [native] update EnumSettingsOption UI.
ginsu updated this revision to Diff 41992.Jul 3 2024, 8:51 PM

update

ginsu added inline comments.Jul 3 2024, 8:52 PM
web/modals/threads/notifications/notifications-modal.react.js
164

Found that this wasn't styled properly, quickly fixed that up + snuck it in this diff

Before:

Screenshot 2024-07-03 at 11.49.26 PM.png (1×3 px, 1 MB)

After:

Screenshot 2024-07-03 at 11.51.47 PM.png (1×3 px, 1 MB)

ginsu attached a referenced file: F2184365: Screenshot 2024-07-03 at 11.51.47 PM.png. (Show Details)Jul 3 2024, 8:53 PM
ginsu attached a referenced file: F2184363: Screenshot 2024-07-03 at 11.49.26 PM.png. (Show Details)
Harbormaster completed remote builds in B30120: Diff 41991.Jul 3 2024, 9:17 PM
Harbormaster completed remote builds in B30121: Diff 41992.Jul 3 2024, 9:21 PM
ginsu requested review of this revision.Jul 3 2024, 9:21 PM
ginsu added a child revision: D12662: [native] introduce thread notif settings notice text.Jul 3 2024, 10:07 PM
ginsu removed a child revision: D12662: [native] introduce thread notif settings notice text.
ginsu added a child revision: D12647: [native] introduce barebones UI for ThreadSettingsNotifications.Jul 3 2024, 10:09 PM
inka accepted this revision.Jul 4 2024, 4:23 AM
This revision is now accepted and ready to land.Jul 4 2024, 4:23 AM
ginsu updated this revision to Diff 42049.Jul 4 2024, 10:58 AM

rebase before landing

Harbormaster completed remote builds in B30158: Diff 42049.Jul 4 2024, 11:21 AM
Closed by commit rCOMMd805cb6dbfba: [lib/native/web] factor out remaining shared logic + copy for thread… (authored by ginsu). · Explain WhyJul 4 2024, 11:21 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd805cb6dbfba: [lib/native/web] factor out remaining shared logic + copy for thread….

Revision Contents
Changeset List

PathSize
lib/
shared/
61 lines
native/
chat/
5 lines
web/
modals/
threads/
notifications/
5 lines
82 lines

Diff 41992

View Options

lib/shared/thread-settings-notifications-utils.js

Loading...
View Options

native/chat/chat.react.js

Loading...
View Options

web/modals/threads/notifications/notifications-modal.css

Loading...
View Options

web/modals/threads/notifications/notifications-modal.react.js

Loading...