issue: ENG-8640
By default all columns of fts5 table are indexed for fulltext search. We want to avoid doing this for original_message_id and message_id which represent message ids. That's why we mark them as UNINDEXED.
From docs:
"It is an error to add types, constraints or PRIMARY KEY declarations to a CREATE VIRTUAL TABLE statement used to create an FTS5 table. "
Details
Details
- Reviewers
tomek kamil - Commits
- rCOMMb6f1abd14fe2: [native](web) Add message_search fts5 table
Tested that the migration and new db setup don't throw
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Heads-up that I landed a different migration 48 in D12759, so you'll have to rebase this one. Sorry about that!
Comment Actions
Heads-up that I landed a different migration 48 in D12759, so you'll have to rebase this one.
Thank you for letting me know!
Comment Actions
Could you update the spacing to match the rest of the file?
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
---|---|---|
893 ↗ | (On Diff #42457) | We have table definitions at the top, and below we define indexes, could you move this above media_idx_container? |
Comment Actions
Could you update the spacing to match the rest of the file?
Please make sure to avoid tab characters! I noticed a bunch of them when I landed migration 48, so I spent some time fixing them up