Introducing validator, unit tests, and consuming in rawThreadInfoValidator which fixes the validator test case which was failing.
This also expands validator so it'll support memberInfos both with and without permissions.
Depends on D12756
Details
Details
Unit tests
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D12758 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
It looks like these validators are used on both the keyserver and the client. It's appropriate for use on the keyserver, which needs to continue supporting older clients.
But it's inappropriate for use on the client, where we don't expect the keyserver to ever respond with the legacy format.
Would love if we could separate these out into two kinds of validators, but it's probably too much work for @atul at this point.
Comment Actions
But it's inappropriate for use on the client, where we don't expect the keyserver to ever respond with the legacy format.
We actually will use this validator on the client. Specifically in convertClientDBThreadInfoToRawThreadInfo where we validate the RawThreadInfo persisted on client. Have a diff that consumes it on client in local stack.
EDIT: To clarify we will consume memberInfoSansPermissionsValidator on the client.
Comment Actions
Going to go ahead and try cherry-picking this onto master to fix the failing validator unit test and get rest of stack "more green."