Page MenuHomePhabricator

[lib] Add `memberInfoSansPermissionsValidator` to `convertClientDBThreadInfoToRawThreadInfo`
ClosedPublic

Authored by atul on Jul 17 2024, 12:36 PM.
Tags
None
Referenced Files
F3134841: D12787.id42405.diff
Sat, Nov 2, 4:10 PM
F3134839: D12787.id42404.diff
Sat, Nov 2, 4:09 PM
F3134838: D12787.id.diff
Sat, Nov 2, 4:09 PM
F3134837: D12787.id42400.diff
Sat, Nov 2, 4:09 PM
F3134823: D12787.diff
Sat, Nov 2, 3:57 PM
Unknown Object (File)
Fri, Nov 1, 7:53 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Subscribers
None

Details

Summary

Added memberInfoSansPermissionsValidator to convertClientDBThreadInfoToRawThreadInfo.

In preparation for client migrations. Moved the more "relevant" validators earlier in conditional so we're doing (almost always) useless legacyMemberInfoValidator check all the time.


Depends on D12779

Test Plan

Will be tested implicitly by client migrations. We have unit tests for memberInfoSansPermissionsValidator.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12787 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Jul 17 2024, 12:53 PM
This revision is now accepted and ready to land.Jul 17 2024, 1:01 PM

Can also cherry-pick and land this to simplify stack before rebasing and addressing all feedback.

This revision was landed with ongoing or failed builds.Jul 17 2024, 1:52 PM
This revision was automatically updated to reflect the committed changes.