Details
Before (thin, with member permissions):
Before (thick, with member permissions):
After (thin, WITHOUT member permissions):
After (thick, still WITH member permissions):
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)
Okay this migration now appears to work.
Would be great if others could test in their environments as well to make sure nothing breaks. Basically just need to patch this in and increment storeVersion to 84 and the migration should run. Can use https://phab.comm.dev/D13561 as reference.
Will make some changes before landing eg
- Go from FlowFixMe to something like FlowIgnore
- Remove logs related skipping ThickThreads
| lib/utils/member-info-utils.js | ||
|---|---|---|
| 46 ↗ | (On Diff #44970) | Can we avoid this if we update ThreadStoreWithMemberPermissions to include thick threads? |
| 48 | Do we really need this log? | |
| web/redux/persist.js | ||
| 656 ↗ | (On Diff #44970) | Can you cast the function to MigrationFunction<WebNavInfo, AppState> to match the other ones, and catch type errors like ops: [] below? |
| 663 ↗ | (On Diff #44970) | Shouldn't this be {}? |