Page MenuHomePhabricator
Differential D12794

[native] Add MessageSearchStoreOperations
ClosedPublic
Actions

Authored by inka on Jul 18 2024, 8:04 AM.
Tags
None
Referenced Files
F3357281: D12794.diff
Sat, Nov 23, 11:21 PM
Unknown Object (File)
Mon, Nov 4, 12:59 PM
Unknown Object (File)
Fri, Nov 1, 7:41 PM
Unknown Object (File)
Oct 18 2024, 8:34 AM
Unknown Object (File)
Oct 14 2024, 5:13 PM
Unknown Object (File)
Oct 14 2024, 5:13 PM
Unknown Object (File)
Oct 14 2024, 5:13 PM
Unknown Object (File)
Oct 14 2024, 5:13 PM
View All 63 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
marcin
Commits
rCOMMefc7925c78bb: [native] Add MessageSearchStoreOperations
Summary

issue: ENG-8832

Test Plan

Tested with following diffs. Added an "add search message" operation on the js side and tested that updateMessageSearchIndex was run and no errors showed up in Metro nor in XCode console

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 18 2024, 8:04 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 18 2024, 8:04 AM
inka added a parent revision: D12783: [web] Add bindings for inserting into the search table.Jul 18 2024, 8:05 AM
inka added a child revision: D12795: [native] Add message search store.Jul 18 2024, 8:08 AM
Harbormaster completed remote builds in B30471: Diff 42470.Jul 18 2024, 8:21 AM
inka requested review of this revision.Jul 18 2024, 8:21 AM
inka added inline comments.Jul 19 2024, 2:58 AM
native/cpp/CommonCpp/NativeModules/MessageSearchStoreOperations.h
10 ↗(On Diff #42470)

I will rename this to UpdateSearchMessagesOperation

marcin accepted this revision.Jul 19 2024, 3:27 AM
This revision is now accepted and ready to land.Jul 19 2024, 3:27 AM
kamil accepted this revision.Jul 19 2024, 5:02 AM
kamil added inline comments.
native/cpp/CommonCpp/NativeModules/MessageSearchStoreOperations.h
10 ↗(On Diff #42470)

probably this convention is broken in different files but we should add #include "DBOperationBase.h" src

inka updated this revision to Diff 42545.Jul 19 2024, 8:00 AM

Rename to UpdateMessageSearchIndexOperation

Harbormaster completed remote builds in B30511: Diff 42545.Jul 19 2024, 8:17 AM
Closed by commit rCOMMefc7925c78bb: [native] Add MessageSearchStoreOperations (authored by inka). · Explain WhyJul 23 2024, 2:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMefc7925c78bb: [native] Add MessageSearchStoreOperations.
kamil added a child revision: D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.Jul 23 2024, 2:51 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
34 lines

Diff 42545

View Options

native/cpp/CommonCpp/NativeModules/MessageSearchStoreOperations.h

Loading...