Paths

Table of Contentst

Differential D12801

[lib][web] Add worker logic for adding search messages
ClosedPublic
Actions

Authored by inka on Jul 19 2024, 3:17 AM.

Tags

None

Referenced Files

	F3357758: D12801.diff
	Sun, Nov 24, 1:23 AM

	Unknown Object (File)
	Mon, Nov 4, 12:55 PM

	Unknown Object (File)
	Mon, Nov 4, 12:48 PM

	Unknown Object (File)
	Fri, Nov 1, 11:26 AM

	Unknown Object (File)
	Oct 18 2024, 12:45 AM

	Unknown Object (File)
	Oct 14 2024, 4:11 PM

	Unknown Object (File)
	Oct 14 2024, 4:11 PM

	Unknown Object (File)
	Oct 14 2024, 4:11 PM

View All 85 Files

Subscribers

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMMed2425b8704c: [lib][web] Add worker logic for adding search messages

Summary

issue: ENG-8645

Test Plan

Added an update_search_messages operation in processDBStoreOperations in redux-utils.js. Tested that updateMessageSearchIndex was run and no errors showed up in the web console and worker console

Diff Detail

Repository

Branch

inka/search

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 19 2024, 3:17 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2024, 3:17 AM

inka added a parent revision: D12796: [native] Add CommCoreModule code for inserting into the search table.Jul 19 2024, 3:17 AM

Harbormaster completed remote builds in B30507: Diff 42520.Jul 19 2024, 3:33 AM

inka requested review of this revision.Jul 19 2024, 3:33 AM

inka added inline comments.Jul 19 2024, 4:06 AM

lib/message-search-types.js
5	This should also be read-only

kamil accepted this revision.Jul 19 2024, 5:20 AM

kamil added inline comments.

lib/message-search-types.js
9	this one is not needed - we don't do any additional parsing, so you can use `MessageSearchStoreOperation` everywhere but if you want to keep it to make naming in `ClientDBStoreOperations` this is also fine

This revision is now accepted and ready to land.Jul 19 2024, 5:20 AM

inka added a child revision: D12833: [lib][web][native] Create message search store ops.Jul 22 2024, 2:02 AM

inka added inline comments.Jul 22 2024, 11:25 PM

lib/message-search-types.js
9	I would rather keep it for consistency

Make read-only

Harbormaster failed remote builds in B30584: Diff 42653!Jul 22 2024, 11:49 PM

Rebase

Harbormaster completed remote builds in B30590: Diff 42659.Jul 23 2024, 2:53 AM

Rebase

Harbormaster completed remote builds in B30605: Diff 42684.Jul 23 2024, 5:44 AM

Closed by commit rCOMMed2425b8704c: [lib][web] Add worker logic for adding search messages (authored by inka). · Explain WhyJul 23 2024, 6:12 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMed2425b8704c: [lib][web] Add worker logic for adding search messages.

Revision Contents
Changeset List

Path

Size

lib/

message-search-types.js

9 lines

types/

store-ops-types.js

2 lines

web/

shared-worker/

worker/

process-operations.js

40 lines

Diff 42520

lib/message-search-types.js

Loading...

lib/types/store-ops-types.js

Loading...

web/shared-worker/worker/process-operations.js

Loading...