Page MenuHomePhabricator
Differential D12964

[native] Register CommunityDrawerButton in nux context
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 1:40 AM.
Tags
None
Referenced Files
F3193576: D12964.id43342.diff
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Wed, Nov 6, 11:17 PM
Unknown Object (File)
Sun, Nov 3, 8:26 PM
Unknown Object (File)
Sun, Nov 3, 8:26 PM
Unknown Object (File)
Sun, Nov 3, 8:24 PM
Unknown Object (File)
Sun, Nov 3, 8:24 PM
Unknown Object (File)
Sun, Nov 3, 8:17 PM
View All 81 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMb635f69eb895: [native] Register CommunityDrawerButton in nux context
Summary

issue: ENG-8618

Test Plan

Tested with following diffs. Tested that after a button registeres their coordinates the handler effect is fired and nux tip appears on the screen, rendering the button in the correct place
Tested that as the button unmounts, the cleanup function is called. Checked that it is not called in unexpected moments

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 5 2024, 1:40 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 1:40 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 1:55 AM
Harbormaster failed remote builds in B30882: Diff 43062!
inka added a parent revision: D12963: [native] Add nux context.Aug 5 2024, 2:23 AM
inka updated this revision to Diff 43101.Aug 5 2024, 5:53 AM

Reabse

inka added a child revision: D12976: [native] Move contentContainerStyle.Aug 5 2024, 6:07 AM
Harbormaster completed remote builds in B30921: Diff 43101.Aug 5 2024, 7:36 AM
inka requested review of this revision.Aug 5 2024, 7:36 AM
ashoat added inline comments.Aug 5 2024, 11:27 AM
native/chat/chat.react.js
403 ↗(On Diff #43101)

Can we pass just tipsContext.registerTipButton in here?

tomek accepted this revision.Aug 6 2024, 2:03 AM
tomek added inline comments.
native/chat/chat.react.js
389–393 ↗(On Diff #43101)

Up to you, but this whole expression can be simplified.

415 ↗(On Diff #43101)

Should we unregister from the context when this button gets unmounted?

This revision is now accepted and ready to land.Aug 6 2024, 2:03 AM
inka updated this revision to Diff 43262.Aug 8 2024, 8:04 AM

Address nits and rebase.
[TODO: UNREGISTER BUTTON AS IT UNMOUNTS]

inka planned changes to this revision.Aug 8 2024, 8:04 AM
Harbormaster completed remote builds in B31013: Diff 43262.Aug 8 2024, 8:25 AM
inka updated this revision to Diff 43342.Aug 13 2024, 6:28 AM

Unregister button

This revision is now accepted and ready to land.Aug 13 2024, 6:28 AM
inka edited the test plan for this revision. (Show Details)Aug 13 2024, 6:29 AM
Harbormaster completed remote builds in B31064: Diff 43342.Aug 13 2024, 6:46 AM
Closed by commit rCOMMb635f69eb895: [native] Register CommunityDrawerButton in nux context (authored by inka). · Explain WhyAug 13 2024, 6:52 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMb635f69eb895: [native] Register CommunityDrawerButton in nux context.

Revision Contents
Changeset List

PathSize
native/
chat/
37 lines
navigation/
15 lines

Diff 43346

View Options

native/chat/chat.react.js

Loading...
View Options

native/navigation/community-drawer-button.react.js

Loading...