issue: ENG-8914
Refactoring from class to function
Details
Details
Tested by creating a nux tooltip and displaying it - still works
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/tooltip/nux-tips-overlay.react.js | ||
---|---|---|
115–119 | Given their similarities, curious that tipVerticalBelow was moved but tipVerticalAbove wasn't. I guess tipVerticalAbove will be moved in a later diff? |
native/tooltip/nux-tips-overlay.react.js | ||
---|---|---|
115–119 | For all current use cases we only need an upward facing triangle. I also wanted to remove as much code as possible, to make this easier to refactor. I think once all of this code is refactored, adding the triangle down, if needed, will be easy. And it helps me to have as little logic as possible. |
native/tooltip/nux-tips-overlay.react.js | ||
---|---|---|
115–119 | I don't think it makes sense to remove the downwards triangle, given that it's definitely useful in a NUX context. I don't see the point of removing and then re-adding "if needed" |