[native] Move tipScale, tipHorizontal
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:07 AM.

Tags

None

Referenced Files

	F3499200: D12982.diff
	Thu, Dec 19, 10:56 PM

	Unknown Object (File)
	Tue, Dec 10, 8:24 PM

	Unknown Object (File)
	Wed, Nov 20, 6:25 AM

	Unknown Object (File)
	Nov 9 2024, 11:38 PM

	Unknown Object (File)
	Nov 6 2024, 11:17 PM

	Unknown Object (File)
	Oct 18 2024, 9:47 PM

	Unknown Object (File)
	Oct 18 2024, 9:47 PM

	Unknown Object (File)
	Oct 18 2024, 9:38 PM

View All 50 Files

Subscribers

ashoat

Details

Reviewers

tomek
will

Commits

rCOMMc877ada6b0e2: [native] Move tipScale, tipHorizontal

Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 5 2024, 6:07 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:07 AM

inka added a parent revision: D12981: [native] Move tipContainerOpacity, tipVerticalBelow, tipHeight, margin.Aug 5 2024, 6:12 AM

inka added a child revision: D12983: [native] Move tipContainerStyle.

Harbormaster completed remote builds in B30930: Diff 43118.Aug 5 2024, 8:44 AM

inka requested review of this revision.Aug 5 2024, 8:44 AM

tomek accepted this revision.Aug 6 2024, 2:29 AM

This revision is now accepted and ready to land.Aug 6 2024, 2:29 AM

Closed by commit rCOMMc877ada6b0e2: [native] Move tipScale, tipHorizontal (authored by inka). · Explain WhyAug 19 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMc877ada6b0e2: [native] Move tipScale, tipHorizontal.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

48 lines

Diff 43118

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Move tipScale, tipHorizontalClosedPublicActions