[native] Remove unused variables
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:10 AM.

Tags

None

Referenced Files

	F3003911: D12984.id43120.diff
	Fri, Oct 18, 11:17 AM

	Unknown Object (File)
	Sun, Oct 6, 7:59 PM

	Unknown Object (File)
	Fri, Oct 4, 7:35 AM

	Unknown Object (File)
	Fri, Oct 4, 6:54 AM

	Unknown Object (File)
	Sun, Sep 29, 2:39 AM

	Unknown Object (File)
	Thu, Sep 26, 8:40 AM

	Unknown Object (File)
	Tue, Sep 24, 2:41 AM

	Unknown Object (File)
	Sat, Sep 21, 11:47 AM

View All 45 Files

Subscribers

ashoat

Details

Reviewers

tomek
will

Commits

rCOMM74fd0eb50b19: [native] Remove unused variables

Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Aug 5 2024, 6:10 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:10 AM

inka added a parent revision: D12983: [native] Move tipContainerStyle.Aug 5 2024, 6:13 AM

inka added a child revision: D12985: [native] Inline code in NUXTipsOverlay.

Harbormaster completed remote builds in B30932: Diff 43120.Aug 5 2024, 8:59 AM

inka requested review of this revision.Aug 5 2024, 8:59 AM

ashoat mentioned this in D12981: [native] Move tipContainerOpacity, tipVerticalBelow, tipHeight, margin.Aug 5 2024, 11:40 AM

tomek accepted this revision.Aug 6 2024, 2:34 AM

This revision is now accepted and ready to land.Aug 6 2024, 2:34 AM

Closed by commit rCOMM74fd0eb50b19: [native] Remove unused variables (authored by inka). · Explain WhyAug 19 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM74fd0eb50b19: [native] Remove unused variables.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

18 lines

Diff 43434

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Remove unused variablesClosedPublicActions