[native] Extract normal style from animated style
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 9:11 AM.

Details

Reviewers

tomek
will

Commits

rCOMMe74d6e4b5c84: [native] Extract normal style from animated style

Summary

issue: ENG-9039
In later diffs, the animations will be handled not by style but by entering and exiting animations.

Test Plan

Tested with later diffs by rendereing a tip that it still looks as it used to

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 13 2024, 9:11 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 13 2024, 9:11 AM

inka added a parent revision: D13066: [native] Refactor background opacity to reanimated 2.Aug 13 2024, 9:12 AM

inka added a child revision: D13070: [native] Update reaniamted flow types.Aug 13 2024, 9:20 AM

Harbormaster completed remote builds in B31078: Diff 43364.Aug 13 2024, 9:29 AM

inka requested review of this revision.Aug 13 2024, 9:29 AM

tomek accepted this revision.Aug 14 2024, 5:53 AM

tomek added inline comments.

native/tooltip/nux-tips-overlay.react.js
205–221	Can we reduce the duplication here?

This revision is now accepted and ready to land.Aug 14 2024, 5:53 AM

inka added inline comments.Aug 19 2024, 7:31 AM

native/tooltip/nux-tips-overlay.react.js
205–221	This is reduced in D13072

Closed by commit rCOMMe74d6e4b5c84: [native] Extract normal style from animated style (authored by inka). · Explain WhyAug 20 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMe74d6e4b5c84: [native] Extract normal style from animated style.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

54 lines

Diff 43364

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Extract normal style from animated styleClosedPublicActions