Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Paths
Table of Contents
t
Hide Panel
f
Keyboard Reference
?
Differential
D13127
[native] Update styling
Closed
Public
Actions
Authored by
inka
on Aug 21 2024, 12:23 AM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
None
Referenced Files
F3341490: D13127.diff
Thu, Nov 21, 11:05 PM
2024-11-21 23:05:43 (UTC-8)
Unknown Object (File)
Wed, Nov 13, 8:34 PM
2024-11-13 20:34:42 (UTC-8)
Unknown Object (File)
Wed, Nov 13, 12:08 AM
2024-11-13 00:08:06 (UTC-8)
Unknown Object (File)
Tue, Nov 12, 4:28 PM
2024-11-12 16:28:52 (UTC-8)
Unknown Object (File)
Sun, Nov 10, 12:27 AM
2024-11-10 00:27:28 (UTC-8)
Unknown Object (File)
Sat, Nov 9, 10:44 PM
2024-11-09 22:44:24 (UTC-8)
Unknown Object (File)
Sat, Nov 9, 10:04 AM
2024-11-09 10:04:34 (UTC-8)
Unknown Object (File)
Sat, Nov 9, 9:59 AM
2024-11-09 09:59:13 (UTC-8)
View All 54 Files
Subscribers
ashoat
Details
Reviewers
tomek
will
Commits
rCOMM68a1821a4d99: [native] Update styling
Summary
issue:
ENG-9058
Test Plan
Please see the screenshots:
Diff Detail
Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Event Timeline
inka
created this revision.
Aug 21 2024, 12:23 AM
2024-08-21 00:23:18 (UTC-7)
Herald
added a subscriber:
ashoat
.
·
View Herald Transcript
Aug 21 2024, 12:23 AM
2024-08-21 00:23:20 (UTC-7)
inka
edited the test plan for this revision.
(Show Details)
Aug 21 2024, 12:23 AM
2024-08-21 00:23:47 (UTC-7)
inka
attached a referenced file:
F2505648: noFID.png
.
(Show Details)
inka
attached a referenced file:
F2505647: Untitled.png
.
(Show Details)
inka
attached a referenced file:
F2505646: drawerTip.png
.
(Show Details)
inka
added a parent revision:
D13120: [native] Make it impossible to skip tips
.
Harbormaster
completed remote builds in
B31189: Diff 43533
.
Aug 21 2024, 12:40 AM
2024-08-21 00:40:17 (UTC-7)
inka
requested review of this revision.
Aug 21 2024, 12:40 AM
2024-08-21 00:40:17 (UTC-7)
tomek
accepted this revision.
Aug 21 2024, 2:56 AM
2024-08-21 02:56:17 (UTC-7)
tomek
added inline comments.
native/tooltip/nux-tips-overlay.react.js
423 ↗
(On Diff #43533)
Isn't it the default?
This revision is now accepted and ready to land.
Aug 21 2024, 2:56 AM
2024-08-21 02:56:17 (UTC-7)
inka
updated this revision to
Diff 43601
.
Aug 23 2024, 4:44 AM
2024-08-23 04:44:54 (UTC-7)
Comment Actions
Remove unnecessary code
Harbormaster
completed remote builds in
B31228: Diff 43601
.
Aug 23 2024, 5:01 AM
2024-08-23 05:01:26 (UTC-7)
inka
added a child revision:
D13136: [native] Fix blinking overlay background
.
Aug 23 2024, 5:09 AM
2024-08-23 05:09:59 (UTC-7)
Closed by commit
rCOMM68a1821a4d99: [native] Update styling
(authored by
inka
).
·
Explain Why
Aug 29 2024, 6:43 AM
2024-08-29 06:43:52 (UTC-7)
This revision was automatically updated to reflect the committed changes.
inka
added a commit:
rCOMM68a1821a4d99: [native] Update styling
.