Page MenuHomePhabricator

[lib] add `outboundP2PMessageIDs` to `LocalMessageInfo` to track progress
ClosedPublic

Authored by kamil on Aug 23 2024, 5:34 AM.
Tags
None
Referenced Files
F3193603: D13153.id43636.diff
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 2:29 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Wed, Oct 23, 2:01 AM
Unknown Object (File)
Wed, Oct 23, 1:14 AM
Unknown Object (File)
Wed, Oct 23, 12:50 AM
Unknown Object (File)
Tue, Oct 22, 2:50 PM
Unknown Object (File)
Tue, Oct 22, 7:15 AM
Subscribers

Details

Summary

ENG-8423.

We decided to use the existing store for local messages for two reasons, to avoid adding a new store, and because in components, LocalMessageInfo is easily accessible (I think it saves us at least a couple of days of work).

Additionally LocalMessageInfo seems like a reasonable place to put this data.

All fields in LocalMessageInfo are optional, which means this does not require a migration.

Depends on D13152

Test Plan

Make sure outboundP2PMessageIDs are persisted & read on app start.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Branch
landing-dms
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 23 2024, 7:25 AM
tomek added inline comments.
lib/reducers/message-reducer.js
1664–1675 ↗(On Diff #43610)

It is a bit hacky. We should at least generate a DB op to update the state.

This revision is now accepted and ready to land.Aug 26 2024, 3:56 AM