Differential D13176

[native] Fix light mode highlighting
ClosedPublic
Actions

Authored by inka on Aug 27 2024, 6:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 16, 4:49 PM

	Unknown Object (File)
	Wed, Apr 16, 12:32 PM

	Unknown Object (File)
	Wed, Apr 16, 7:35 AM

	Unknown Object (File)
	Tue, Apr 15, 2:45 PM

	Unknown Object (File)
	Mon, Apr 14, 7:23 PM

	Unknown Object (File)
	Sat, Apr 12, 1:27 AM

	Unknown Object (File)
	Thu, Apr 10, 12:47 AM

	Unknown Object (File)
	Wed, Apr 9, 11:12 PM

View All 72 Files

Subscribers

Details

Reviewers

Commits

rCOMMf6065bd584ae: [native] Fix light mode highlighting

Summary

@tomek requested updating the style because the light mode was looking broken

Test Plan

please see the comparison:
before:

after:

Diff Detail

Repository

Branch

inka/nux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 27 2024, 6:33 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2024, 6:33 AM

inka mentioned this in D13084: [native] Create muted tab tip.Aug 27 2024, 6:35 AM

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F2556804: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-27 at 15.34.28.mp4. (Show Details)

inka attached a referenced file: F2556807: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-27 at 15.31.39.mp4. (Show Details)

inka added a parent revision: D13175: [native] Add renderTabBarItem to MaterialTopTabBarProps.

Harbormaster completed remote builds in B31288: Diff 43680.Aug 27 2024, 6:52 AM

inka requested review of this revision.Aug 27 2024, 6:52 AM

Thanks!

This revision is now accepted and ready to land.Aug 27 2024, 7:13 AM

inka edited parent revisions, added: D13136: [native] Fix blinking overlay background; removed: D13175: [native] Add renderTabBarItem to MaterialTopTabBarProps.Aug 27 2024, 7:39 AM

inka added a child revision: D13178: [native] Move ChatTabBarButton.Aug 27 2024, 8:59 AM

Closed by commit rCOMMf6065bd584ae: [native] Fix light mode highlighting (authored by inka). · Explain WhyAug 29 2024, 6:43 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMf6065bd584ae: [native] Fix light mode highlighting.

Revision Contents
Changeset List

Path

Size

native/

navigation/

community-drawer-button-icon.react.js

13 lines

Diff 43680

native/navigation/community-drawer-button-icon.react.js

	// @flow			// @flow

	export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE			export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'primary'			? process.env.COMM_NODE_ROLE === 'primary'
	: true;			: true;

	export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE			export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'secondary'			? process.env.COMM_NODE_ROLE === 'secondary'
	: false;			: false;

				export const isAuxiliaryNode: boolean = process.env.COMM_NODE_ROLE
				? process.env.COMM_NODE_ROLE === 'auxiliary'
				: false;