Page MenuHomePhabricator
Differential D13180

[native] Create intro tip
ClosedPublic
Actions

Authored by inka on Aug 27 2024, 10:06 AM.
Tags
None
Referenced Files
F3498129: D13180.id43807.diff
Thu, Dec 19, 8:52 PM
F3497840: D13180.id43735.diff
Thu, Dec 19, 8:00 PM
Unknown Object (File)
Sat, Dec 14, 9:01 PM
Unknown Object (File)
Nov 10 2024, 11:32 AM
Unknown Object (File)
Nov 10 2024, 7:20 AM
Unknown Object (File)
Nov 10 2024, 6:43 AM
Unknown Object (File)
Nov 10 2024, 4:42 AM
Unknown Object (File)
Nov 9 2024, 11:36 PM
View All 61 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM77917832dbed: [native] Create intro tip
Summary

issue: ENG-9062

Test Plan

Please see the video:

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 27 2024, 10:06 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2024, 10:06 AM
inka added a parent revision: D13179: [native] Make possible to render tip not pointing to anything.Aug 27 2024, 10:07 AM
inka edited the test plan for this revision. (Show Details)
inka attached a referenced file: F2559147: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-27 at 18.55.48.mp4. (Show Details)
Harbormaster completed remote builds in B31301: Diff 43702.Aug 27 2024, 10:33 AM
inka requested review of this revision.Aug 27 2024, 10:33 AM
tomek accepted this revision.Aug 28 2024, 4:08 AM
tomek added inline comments.
native/components/nux-tips-context.react.js
112–114

Can we check this based on the spec?

This revision is now accepted and ready to land.Aug 28 2024, 4:08 AM
inka added inline comments.Aug 28 2024, 4:23 AM
native/components/nux-tips-context.react.js
112–114

I like that! Thanks!

inka updated this revision to Diff 43735.Aug 28 2024, 4:23 AM

Address review

inka added inline comments.Aug 28 2024, 5:40 AM
native/components/nux-tips-context.react.js
112–114

Actually that doesn't work, because location is the location the key route is supposed to pass in its props.

inka updated this revision to Diff 43736.Aug 28 2024, 5:43 AM

Revert

Harbormaster completed remote builds in B31328: Diff 43736.Aug 28 2024, 5:59 AM
inka added a child revision: D13194: [native] Simplify nux tips props design.Aug 28 2024, 7:05 AM
inka added a comment.Aug 28 2024, 7:07 AM

Changed some things in the design in D13194, so @tomek's suggestion was possible be applied there

Closed by commit rCOMM77917832dbed: [native] Create intro tip (authored by inka). · Explain WhyAug 29 2024, 6:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM77917832dbed: [native] Create intro tip.

Revision Contents
Changeset List

PathSize
native/
components/
12 lines
navigation/
3 lines
17 lines
2 lines
3 lines

Diff 43702

View Options

native/components/nux-tips-context.react.js

Loading...
View Options

native/navigation/app-navigator.react.js

Loading...
View Options

native/navigation/intro-tip.react.js

Loading...
View Options

native/navigation/overlay-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...