[blob] Add support for removing holders by tags
Needs ReviewPublic
Actions

Authored by bartek on Wed, Oct 9, 1:22 AM.

Details

Reviewers

kamil
varun
will

Summary

In D13646, a request format was extended to support removing holders by tags. Now server-side support is added.

Depends on D13646, D13618

Test Plan

Played with the DELETE /holders endpoint in Postman. Added some prefixed holders and verified that they were removed from DDB

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Wed, Oct 9, 1:22 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Oct 9, 1:22 AM

bartek added a child revision: D13648: [comm-lib][blob-client] Add support for removing holders by tags.Wed, Oct 9, 1:26 AM

Harbormaster completed remote builds in B32127: Diff 44997.Wed, Oct 9, 1:51 AM

bartek published this revision for review.Wed, Oct 9, 2:20 AM

bartek added inline comments.

services/blob/src/service.rs
50–54	We should always map these explicitly, so `from(ignore)` makes sense to disable auto-conversion

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

holders.rs

20 lines

service.rs

39 lines

Diff 44997

View Options

services/blob/src/http/handlers/holders.rs