Paths

Table of Contentst

Differential D13647

[blob] Add support for removing holders by tags
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:22 AM.

Tags

None

Referenced Files

	F3335845: D13647.diff
	Thu, Nov 21, 11:27 AM

	Unknown Object (File)
	Fri, Nov 15, 7:03 AM

	Unknown Object (File)
	Thu, Nov 14, 6:57 PM

	Unknown Object (File)
	Thu, Nov 14, 3:51 PM

	Unknown Object (File)
	Tue, Nov 12, 2:39 PM

	Unknown Object (File)
	Sat, Nov 9, 3:56 AM

	Unknown Object (File)
	Sat, Nov 9, 2:23 AM

	Unknown Object (File)
	Thu, Nov 7, 6:07 AM

View All 43 Files

Subscribers

Details

Reviewers

kamil
varun
will

Commits

rCOMM20d0368eeb53: [blob] Add support for removing holders by tags

Summary

In D13646, a request format was extended to support removing holders by tags. Now server-side support is added.

Depends on D13646, D13618

Test Plan

Played with the DELETE /holders endpoint in Postman. Added some prefixed holders and verified that they were removed from DDB

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 9 2024, 1:22 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2024, 1:22 AM

bartek added a child revision: D13648: [comm-lib][blob-client] Add support for removing holders by tags.Oct 9 2024, 1:26 AM

Harbormaster completed remote builds in B32127: Diff 44997.Oct 9 2024, 1:51 AM

bartek published this revision for review.Oct 9 2024, 2:20 AM

bartek added inline comments.

services/blob/src/service.rs
50–54 ↗	(On Diff #44997)	We should always map these explicitly, so `from(ignore)` makes sense to disable auto-conversion

kamil requested changes to this revision.Oct 10 2024, 2:16 AM

kamil added inline comments.

services/blob/src/http/handlers/holders.rs
62 ↗	(On Diff #44997)	since we can query holders, we should make sure this is called only by service to forbid malicious users from deleting other user's holders

This revision now requires changes to proceed.Oct 10 2024, 2:16 AM

Address feedback. Deleting holders by querying tags now requires a s2s token.

Harbormaster completed remote builds in B32176: Diff 45051.Oct 10 2024, 5:49 AM

kamil accepted this revision.Oct 10 2024, 7:40 AM

This revision is now accepted and ready to land.Oct 10 2024, 7:40 AM

Closed by commit rCOMM20d0368eeb53: [blob] Add support for removing holders by tags (authored by bartek). · Explain WhyOct 14 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM20d0368eeb53: [blob] Add support for removing holders by tags.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

36 lines

39 lines

Diff 45051

services/blob/src/http/handlers/holders.rs

Loading...

services/blob/src/service.rs

Loading...