[comm-lib][blob-client] Add support for removing holders by tags
Needs ReviewPublic
Actions

Authored by bartek on Wed, Oct 9, 1:26 AM.

Details

Reviewers

kamil
varun
will

Summary

In D13646 and D13647 a support for removing holders by tag was added. This diff adds support for this feature in BlobServiceClient.
Added some convenience conversion traits.

Depends on D13647

Test Plan

Same as D13644 but also used tagged holders

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Wed, Oct 9, 1:26 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Oct 9, 1:26 AM

bartek added a child revision: D13650: [identity] Add function to remove holders for devices.Wed, Oct 9, 1:34 AM

Harbormaster completed remote builds in B32128: Diff 44998.Wed, Oct 9, 1:54 AM

bartek published this revision for review.Wed, Oct 9, 2:22 AM

bartek added inline comments.

shared/comm-lib/src/blob/types.rs
89–93	As long as the previous trait makes sense (see above comment edit), I'm doubtful about this one. Somebody might think that this allows auto-conversion for a vec of holders. I'll probably remove it to avoid confusion