Page MenuHomePhabricator
Differential D13648

[comm-lib][blob-client] Add support for removing holders by tags
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:50 PM
Unknown Object (File)
Thu, Nov 21, 5:14 PM
Unknown Object (File)
Thu, Nov 21, 4:23 PM
Unknown Object (File)
Thu, Nov 21, 11:21 AM
Unknown Object (File)
Wed, Nov 20, 9:13 AM
Unknown Object (File)
Wed, Nov 20, 9:13 AM
Unknown Object (File)
Thu, Nov 14, 9:58 PM
Unknown Object (File)
Thu, Nov 14, 3:00 PM
View All 44 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMMb5d7583ea75d: [comm-lib][blob-client] Add support for removing holders by tags
Summary

In D13646 and D13647 a support for removing holders by tag was added. This diff adds support for this feature in BlobServiceClient.
Added some convenience conversion traits.

Depends on D13647

Test Plan

Same as D13644 but also used tagged holders

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Oct 9 2024, 1:26 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2024, 1:26 AM
bartek added a child revision: D13650: [identity] Add function to remove holders for devices.Oct 9 2024, 1:34 AM
Harbormaster completed remote builds in B32128: Diff 44998.Oct 9 2024, 1:54 AM
bartek published this revision for review.Oct 9 2024, 2:22 AM
bartek added inline comments.
shared/comm-lib/src/blob/types.rs
89–93 ↗(On Diff #44998)

As long as the previous trait makes sense (see above comment edit), I'm doubtful about this one. Somebody might think that this allows auto-conversion for a vec of holders. I'll probably remove it to avoid confusion

kamil accepted this revision.Oct 10 2024, 2:23 AM
kamil added inline comments.
shared/comm-lib/src/blob/types.rs
89–93 ↗(On Diff #44998)

Agree

This revision is now accepted and ready to land.Oct 10 2024, 2:23 AM
kamil mentioned this in D13650: [identity] Add function to remove holders for devices.Oct 10 2024, 2:34 AM
bartek updated this revision to Diff 45148.Oct 14 2024, 5:03 AM

Remove confusing impl

Harbormaster completed remote builds in B32226: Diff 45148.Oct 14 2024, 5:20 AM
Closed by commit rCOMMb5d7583ea75d: [comm-lib][blob-client] Add support for removing holders by tags (authored by bartek). · Explain WhyOct 14 2024, 7:20 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMb5d7583ea75d: [comm-lib][blob-client] Add support for removing holders by tags.

Revision Contents
Changeset List

PathSize
shared/
comm-lib/
src/
blob/
26 lines
10 lines

Diff 45148

View Options

shared/comm-lib/src/blob/client.rs

Loading...
View Options

shared/comm-lib/src/blob/types.rs

Loading...