Page MenuHomePhabricator

[identity] Remove blob holders on logout and account deletion
Needs ReviewPublic

Authored by bartek on Wed, Oct 9, 1:45 AM.
Tags
None
Referenced Files
F2929660: D13652.diff
Wed, Oct 9, 4:27 PM
F2929149: D13652.id.diff
Wed, Oct 9, 12:37 PM
F2928886: D13652.diff
Wed, Oct 9, 8:36 AM
F2928885: D13652.diff
Wed, Oct 9, 8:35 AM
Subscribers

Details

Reviewers
varun
will
kamil
Summary

Final diff for ENG-9368.

  • Besides Tunnelbroker and Backup data, blob holders are also removed
  • Some renames

Depends on D13651

Test Plan

Mocked this by creating a device by Commtest, manually added some holders prefixed by its device ID, then logging it out (also with commtest).
Checked Identity logs and DDB by querying for indexed_tag=deviceID. Verified that holders were gone.

Final testing will be done on staging:

  • Log in a device, jot down its device ID, start a DM thread, set avatar to image, then reset back to emoji.
  • Simulate blob service connection error - change blob URL client to fake, or comment-out the call and return failure.
  • Log out the device.
  • Verify Identity logs and DDB by querying for indexed_tag=deviceID. Holders should be gone.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage