Page MenuHomePhabricator

[identity] Remove blob holders on logout and account deletion
ClosedPublic

Authored by bartek on Oct 9 2024, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 12:12 PM
Unknown Object (File)
Tue, Apr 22, 8:19 AM
Unknown Object (File)
Mon, Apr 21, 9:43 PM
Unknown Object (File)
Mon, Apr 21, 9:22 PM
Unknown Object (File)
Mon, Apr 21, 1:01 AM
Unknown Object (File)
Tue, Apr 8, 9:06 PM
Unknown Object (File)
Mar 15 2025, 3:18 AM
Unknown Object (File)
Feb 17 2025, 10:20 AM
Subscribers

Details

Summary

Final diff for ENG-9368.

  • Besides Tunnelbroker and Backup data, blob holders are also removed
  • Some renames

Depends on D13651

Test Plan

Mocked this by creating a device by Commtest, manually added some holders prefixed by its device ID, then logging it out (also with commtest).
Checked Identity logs and DDB by querying for indexed_tag=deviceID. Verified that holders were gone.

Final testing will be done on staging:

  • Log in a device, jot down its device ID, start a DM thread, set avatar to image, then reset back to emoji.
  • Simulate blob service connection error - change blob URL client to fake, or comment-out the call and return failure.
  • Log out the device.
  • Verify Identity logs and DDB by querying for indexed_tag=deviceID. Holders should be gone.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable