Page MenuHomePhabricator

[commtest] use registered `UserIdentity` in backup tests
ClosedPublic

Authored by kamil on Oct 29 2024, 7:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 3:29 PM
Unknown Object (File)
Wed, Nov 27, 1:49 PM
Unknown Object (File)
Tue, Nov 26, 6:26 AM
Unknown Object (File)
Sat, Nov 23, 8:16 AM
Unknown Object (File)
Sat, Nov 23, 4:53 AM
Unknown Object (File)
Fri, Nov 22, 8:29 AM
Unknown Object (File)
Tue, Nov 19, 3:15 AM
Unknown Object (File)
Fri, Nov 15, 7:34 AM
Subscribers

Details

Summary

ENG-6145.

Later, we'll need to get userID from Identity to download backup, to make it work we need to use existing user instead of mocks.

Depends on D13803

Test Plan

Run commtest

Diff Detail

Repository
rCOMM Comm
Branch
backup-work
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Oct 30 2024, 9:28 AM
This revision is now accepted and ready to land.Fri, Nov 1, 1:28 PM
services/commtest/tests/backup_integration_test.rs
27–31 ↗(On Diff #45426)
let user_identity = UserIdentity {
    user_id: device_info.user_id.clone(),
    ..device_info
};

i think this shorthand should work

services/commtest/tests/backup_performance_test.rs
49–56 ↗(On Diff #45426)

if shorthand from above works, might want to use it here too

services/commtest/tests/backup_integration_test.rs
27–31 ↗(On Diff #45426)

it's not working because of ^^^^^^^^^^^ expected UserIdentity, found DeviceInfo - but I am going to refactor this in the next diffs anyway

services/commtest/tests/backup_integration_test.rs
27–31 ↗(On Diff #45426)

improved in D13872