Page MenuHomePhabricator
Differential D13805

[commtest] use registered `UserIdentity` in backup tests
ClosedPublic
Actions

Authored by kamil on Tue, Oct 29, 7:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 6:26 AM
Unknown Object (File)
Sat, Nov 23, 8:16 AM
Unknown Object (File)
Sat, Nov 23, 4:53 AM
Unknown Object (File)
Fri, Nov 22, 8:29 AM
Unknown Object (File)
Tue, Nov 19, 3:15 AM
Unknown Object (File)
Fri, Nov 15, 7:34 AM
Unknown Object (File)
Mon, Nov 11, 7:34 AM
Unknown Object (File)
Sun, Nov 10, 9:02 PM
View All 31 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMc44768a780d3: [commtest] use registered `UserIdentity` in backup tests
Summary

ENG-6145.

Later, we'll need to get userID from Identity to download backup, to make it work we need to use existing user instead of mocks.

Depends on D13803

Test Plan

Run commtest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Oct 29, 7:59 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Oct 29, 7:59 AM
Harbormaster failed remote builds in B32401: Diff 45423!Tue, Oct 29, 8:12 AM
kamil updated this revision to Diff 45426.Tue, Oct 29, 8:40 AM

rebase

kamil added a child revision: D13806: [backup-service] implement calling `FindUserID` RPC from Backup.Tue, Oct 29, 8:41 AM
Harbormaster completed remote builds in B32404: Diff 45426.Tue, Oct 29, 8:58 AM
kamil published this revision for review.Wed, Oct 30, 9:28 AM
varun accepted this revision.Fri, Nov 1, 1:28 PM
This revision is now accepted and ready to land.Fri, Nov 1, 1:28 PM
varun added inline comments.Fri, Nov 1, 1:30 PM
services/commtest/tests/backup_integration_test.rs
27–31 ↗(On Diff #45426)
let user_identity = UserIdentity {
    user_id: device_info.user_id.clone(),
    ..device_info
};

i think this shorthand should work

services/commtest/tests/backup_performance_test.rs
49–56 ↗(On Diff #45426)

if shorthand from above works, might want to use it here too

bartek accepted this revision.Mon, Nov 4, 4:56 AM
kamil added inline comments.Tue, Nov 5, 4:10 AM
services/commtest/tests/backup_integration_test.rs
27–31 ↗(On Diff #45426)

it's not working because of ^^^^^^^^^^^ expected UserIdentity, found DeviceInfo - but I am going to refactor this in the next diffs anyway

kamil added inline comments.Tue, Nov 5, 6:08 AM
services/commtest/tests/backup_integration_test.rs
27–31 ↗(On Diff #45426)

improved in D13872

Closed by commit rCOMMc44768a780d3: [commtest] use registered `UserIdentity` in backup tests (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc44768a780d3: [commtest] use registered `UserIdentity` in backup tests.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
12 lines
17 lines

Diff 45661

View Options

services/commtest/tests/backup_integration_test.rs

Loading...
View Options

services/commtest/tests/backup_performance_test.rs

Loading...