Paths

Table of Contentst

Differential D13808

[backup-service][backup-client] rename `username` -> `user_identifier`
ClosedPublic
Actions

Authored by kamil on Tue, Oct 29, 9:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 3:12 AM

	Unknown Object (File)
	Fri, Nov 15, 9:38 PM

	Unknown Object (File)
	Fri, Nov 15, 6:35 AM

	Unknown Object (File)
	Thu, Nov 14, 3:48 AM

	Unknown Object (File)
	Sun, Nov 10, 3:33 PM

	Unknown Object (File)
	Sun, Nov 10, 12:47 AM

	Unknown Object (File)
	Sat, Nov 9, 7:14 PM

	Unknown Object (File)
	Sat, Nov 9, 6:48 AM

View All 24 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMMa966b4320fa6: [backup-service][backup-client] rename `username` -> `user_identifier`

Summary

username is consfusing, as it could be the Wallet address too

Depends on D13807

Test Plan

run commtest

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Oct 29, 9:19 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Oct 29, 9:19 AM

kamil added a child revision: D13809: [backup-service][backup-client] update `/latest` endpoint to return both `backupID` and `userID`.Tue, Oct 29, 9:28 AM

Harbormaster failed remote builds in B32407: Diff 45430!Tue, Oct 29, 9:45 AM

kamil added inline comments.Wed, Oct 30, 3:35 AM

native/native_rust_library/src/backup.rs
328 ↗	(On Diff #45430)	this is going to be updated later as part of Native changes for minimal version of backup

rebase

Harbormaster completed remote builds in B32430: Diff 45457.Wed, Oct 30, 4:07 AM

kamil published this revision for review.Wed, Oct 30, 9:29 AM

varun requested changes to this revision.Fri, Nov 1, 2:17 PM

varun added inline comments.

native/native_rust_library/src/backup.rs
334 ↗	(On Diff #45457)	confused why we use user_id here

This revision now requires changes to proceed.Fri, Nov 1, 2:17 PM

kamil requested review of this revision.Sun, Nov 3, 11:25 PM

kamil added inline comments.

native/native_rust_library/src/backup.rs
334 ↗	(On Diff #45457)	We don't have a `user_identifier` (username/wallet) here. The initial version of the backup used `user_id` - and the point of this whole stack is to change this, this diff is only about renaming service and client prop. Later in the stack in D13837 I implemented code that uses `user_identifier` correctly, in D13849 I updated rest of the code to start using this and this particular method is removed. I know this is confusing, but there was not better option to slice it for diffs, I could either cause CI falling or submit one diff with squashed all commits form this stack.

bartek accepted this revision.Mon, Nov 4, 4:55 AM

varun accepted this revision.Mon, Nov 4, 7:31 AM

This revision is now accepted and ready to land.Mon, Nov 4, 7:31 AM

rebase

Harbormaster failed remote builds in B32536: Diff 45604!Tue, Nov 5, 4:32 AM

Harbormaster completed remote builds in B32536: Diff 45604.Tue, Nov 5, 4:49 AM

Closed by commit rCOMMa966b4320fa6: [backup-service][backup-client] rename `username` -> `user_identifier` (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa966b4320fa6: [backup-service][backup-client] rename `username` -> `user_identifier`.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

4 lines

services/

backup/

src/

http/

handlers/

8 lines

4 lines

commtest/

tests/

backup_integration_test.rs

4 lines

backup_performance_test.rs

9 lines

shared/

backup_client/

src/

6 lines

Diff 45665

native/native_rust_library/src/backup.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

services/backup/src/http/mod.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...

shared/backup_client/src/lib.rs

Loading...