[lib] Fetch older messages when showInMessagePreview rejects messages in local store
ClosedPublic
Actions

Authored by ashoat on Oct 30 2024, 11:49 AM.

Details

Reviewers

tomek

Commits

rCOMMed21b47bc85e: [lib] Fetch older messages when showInMessagePreview rejects messages in local…

Summary

This diff implements "Potential solution 3" described on Linear here.

Depends on D13830

Test Plan

Tested in combination with the rest of the stack:

Make sure membership operations (user joining / leaving) don't appear in MessagePreview
Make sure reactions to the viewer's messages still appear in MessagePreview
Make sure reactions to other user's messages don't appear in MessagePreview
Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 30 2024, 11:49 AM

ashoat added inline comments.Oct 30 2024, 12:00 PM

lib/hooks/message-hooks.js
127 ↗	(On Diff #45481)	I included this `sleep` here for two reasons: In case we need repeated fetches, I figured it would be better for performance to avoid having them all occur in rapid succession. There may be some delay between when the call resolves and when the Redux store is updated. Ideally we would watch the Redux store and flip `setCanFetchOlderMessages` when the new messages come in, but that would be rather complicated.

Harbormaster completed remote builds in B32448: Diff 45481.Oct 30 2024, 1:20 PM

ashoat requested review of this revision.Oct 30 2024, 1:20 PM

This approach sounds dangerous because it can potentially result in fetching a huge number of messages into memory. However, the scenario in which that could happen is almost impossible.

This revision is now accepted and ready to land.Oct 31 2024, 6:15 AM

ashoat added a child revision: D13828: [lib] Only show reactions to viewer's messages in MessagePreview.Oct 31 2024, 11:10 AM

Closed by commit rCOMMed21b47bc85e: [lib] Fetch older messages when showInMessagePreview rejects messages in local… (authored by ashoat). · Explain WhyOct 31 2024, 11:38 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMed21b47bc85e: [lib] Fetch older messages when showInMessagePreview rejects messages in local….