Page MenuHomePhabricator
Differential D13912

[lib] Extract getLastUpdatedTime to a separate file
ClosedPublic
Actions

Authored by ashoat on Nov 12 2024, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Wed, Dec 18, 4:14 PM
Unknown Object (File)
Wed, Dec 18, 4:13 PM
Unknown Object (File)
Sat, Dec 7, 4:32 PM
Unknown Object (File)
Tue, Dec 3, 6:58 PM
View All 37 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM2f9b274e6865: [lib] Extract getLastUpdatedTime to a separate file
rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file
Summary

This will make a following diff a little easier.

Note that this isn't a pure move; I've removed the isEmptyMediaMessage check, which will be reimplemented inside a message spec in the next diff.

Depends on D13911

Test Plan

Flow. Also tested in combination with the rest of the stack

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Nov 12 2024, 12:40 PM
ashoat edited the summary of this revision. (Show Details)Nov 12 2024, 12:40 PM
ashoat added inline comments.
lib/selectors/chat-selectors.js
106 ↗(On Diff #45759)

Note that this isn't a pure move; I've removed the isEmptyMediaMessage check, which will be reimplemented inside a message spec in the next diff.

ashoat added a child revision: D13913: [lib] Introduce MessageSpec.getLastUpdatedTime.Nov 12 2024, 12:41 PM
Harbormaster completed remote builds in B32623: Diff 45759.Nov 12 2024, 1:07 PM
ashoat requested review of this revision.Nov 12 2024, 1:07 PM
tomek accepted this revision.Nov 13 2024, 3:38 AM
This revision is now accepted and ready to land.Nov 13 2024, 3:38 AM
Closed by commit rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file (authored by ashoat). · Explain WhyNov 13 2024, 11:20 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM084e0062ebd5: [lib] Extract getLastUpdatedTime to a separate file.
ashoat added a reverting change: rCOMMed098ff1dcae: Revert "[lib] Extract getLastUpdatedTime to a separate file".Tue, Dec 10, 8:24 AM
ashoat reopened this revision.Tue, Dec 10, 8:24 AM
This revision is now accepted and ready to land.Tue, Dec 10, 8:24 AM
ashoat updated this revision to Diff 46290.Tue, Dec 10, 8:26 AM

Rebase

Harbormaster completed remote builds in B32984: Diff 46290.Tue, Dec 10, 8:45 AM
Closed by commit rCOMM2f9b274e6865: [lib] Extract getLastUpdatedTime to a separate file (authored by ashoat). · Explain WhyFri, Dec 13, 6:13 AM
This revision was automatically updated to reflect the committed changes.
Ashoat Tevosyan <ashoat@gmail.com> added a commit: rCOMM2f9b274e6865: [lib] Extract getLastUpdatedTime to a separate file.

Revision Contents
Changeset List

PathSize
lib/
hooks/
25 lines
selectors/
20 lines

Diff 46290

View Options

lib/hooks/thread-time.js

Loading...
View Options

lib/selectors/chat-selectors.js

Loading...