Page MenuHomePhabricator
Differential D5409

[native] [16/34] ReactNav6: clean up Navigator props
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:15 AM.
Tags
None
Referenced Files
F3249077: D5409.diff
Fri, Nov 15, 12:18 PM
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Tue, Oct 29, 3:04 PM
Unknown Object (File)
Mon, Oct 28, 5:08 AM
Unknown Object (File)
Mon, Oct 28, 5:08 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Oct 1 2024, 5:23 AM
Unknown Object (File)
Sep 26 2024, 7:08 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMMeeedc177fa73: [native] [16/34] ReactNav6: clean up Navigator props
Summary
  1. Introduce new NavigatorProps type to Unify all of the different types that represent Navigator props
  2. Make sure screenListeners is included on NavigatorPropsBase and CreateNavigatorFactory, rather than only on CreateNavigator and the various *NavigatorProps types
  3. Introduce new ScreenListenersProp component with the same approach as ScreenOptionsProp
  4. Make corresponding changes to all three of our custom navigators, so that they match createStackNavigator upstream (defaultScreenOptions is still missing – will be addressed in a later diff)

Depends on D5408

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 6:15 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:15 AM
ashoat added a child revision: D5410: [native] [17/34] ReactNav6: Fix up BaseNavigationContainerInterface type.Oct 20 2022, 6:15 AM
ashoat mentioned this in D5411: [native] [18/34] ReactNav6: Unify listeners and options props between screens and navigators.
ashoat mentioned this in D5412: [native] [19/34] ReactNav6: Update UseNavigationBuilder type.
Harbormaster completed remote builds in B12896: Diff 17687.Oct 20 2022, 6:50 AM
ashoat requested review of this revision.Oct 20 2022, 6:50 AM
atul accepted this revision.Oct 20 2022, 11:35 AM
This revision is now accepted and ready to land.Oct 20 2022, 11:35 AM
Closed by commit rCOMMeeedc177fa73: [native] [16/34] ReactNav6: clean up Navigator props (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMeeedc177fa73: [native] [16/34] ReactNav6: clean up Navigator props.
ashoat mentioned this in rCOMMcf62d28c0d44: [native] [18/34] ReactNav6: Unify listeners and options props between screens….
ashoat mentioned this in rCOMMf5a7d0a78bf9: [native] [19/34] ReactNav6: Update UseNavigationBuilder type.

Revision Contents
Changeset List

PathSize
native/
chat/
2 lines
flow-typed/
npm/
@react-navigation/
142 lines
142 lines
142 lines
142 lines
142 lines
navigation/
12 lines
2 lines

Diff 17687

View Options

native/chat/chat.react.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...
View Options

native/navigation/overlay-navigator.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...