Page MenuHomePhabricator
Differential D7266

[keyserver] Set innodb-ft-min-token-size and innodb-ft-enable-stopword variables
ClosedPublic
Actions

Authored by inka on Mar 31 2023, 2:23 AM.
Tags
None
Referenced Files
F3389477: D7266.diff
Fri, Nov 29, 7:18 PM
Unknown Object (File)
Sun, Nov 10, 4:22 PM
Unknown Object (File)
Sun, Nov 10, 2:43 PM
Unknown Object (File)
Sun, Nov 10, 9:56 AM
Unknown Object (File)
Sun, Nov 10, 9:15 AM
Unknown Object (File)
Thu, Nov 7, 4:32 AM
Unknown Object (File)
Thu, Nov 7, 4:31 AM
Unknown Object (File)
Wed, Nov 6, 3:26 AM
View All Files
Subscribers
atul

Details

Reviewers
ashoat
tomek
• jon
Commits
rCOMM9e1935167b70: [keyserver] Set innodb-ft-min-token-size and innodb-ft-enable-stopword variables
Summary

issue: https://linear.app/comm/issue/ENG-3349/test-setting-innodb-ft-min-token-size
innodb-ft-min-token-size sets the minimum length of words stored in an InnoDB FULLTEXT index. We set it to 1, because we want words of any length to be indexed.
innodb-ft-enable-stopword set to 0 tells innodb to not use its list of stopwords. We want to handle them ourselves in js, and just not insert them into the search table.

Test Plan

Run keyserver in docker and checked that the variables are indeed set to those values (by connecting to the db and running SHOW VARIABLES LIKE 'innodb_ft%';). Added to the message_search table rows with words of length 1 and 2, and checked that MATCH AGAINST query finds them. Checked that innodb stopwords also match.

image.png (620×1 px, 68 KB)

image.png (802×1 px, 87 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Mar 31 2023, 2:23 AM
Herald added a subscriber: atul. · View Herald TranscriptMar 31 2023, 2:23 AM
inka added a child revision: D7076: [keyserver] Add search table to the db.Mar 31 2023, 2:23 AM
inka edited the summary of this revision. (Show Details)Mar 31 2023, 2:26 AM
inka edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B17862: Diff 24466.Mar 31 2023, 2:39 AM
inka requested review of this revision.Mar 31 2023, 2:39 AM
tomek accepted this revision.Mar 31 2023, 5:38 AM

This looks ok, but we should also update the databases in our local environments. Do we have a plan for this?

This revision is now accepted and ready to land.Mar 31 2023, 5:38 AM
inka mentioned this in D7296: [nix] Set db variables in our local environments.Apr 4 2023, 4:00 AM
inka added a parent revision: D7296: [nix] Set db variables in our local environments.Apr 4 2023, 4:00 AM
In D7266#216296, @tomek wrote:

This looks ok, but we should also update the databases in our local environments. Do we have a plan for this?

D7296 addresses this

• InkaSokolowska mentioned this in rCOMMeaf79b7b72a8: [nix] Set db variables in our local environments.Apr 5 2023, 2:55 AM
Closed by commit rCOMM9e1935167b70: [keyserver] Set innodb-ft-min-token-size and innodb-ft-enable-stopword variables (authored by • InkaSokolowska). · Explain WhyApr 7 2023, 6:21 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM9e1935167b70: [keyserver] Set innodb-ft-min-token-size and innodb-ft-enable-stopword variables.

Revision Contents
Changeset List

PathSize
keyserver/
2 lines

Diff 24466

View Options

keyserver/docker-compose.yml

Loading...