[native] Add EditState to the InputState
ClosedPublic
Actions

Authored by • kuba on Apr 7 2023, 6:55 AM.

Details

Reviewers

michal
inka
ginsu

Commits

rCOMM921b8bba564c: [native] Add EditState to the InputState

Summary

Added EditState which stores information about which message is being currently edited.

Test Plan

Run the app, and check if it still works. More tests are in later diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.Apr 7 2023, 6:55 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 6:55 AM

• kuba added a child revision: D7343: [native] Added edit button to the Tooltip.Apr 7 2023, 6:56 AM

Harbormaster completed remote builds in B18081: Diff 24781.Apr 7 2023, 7:11 AM

• kuba requested review of this revision.Apr 7 2023, 7:11 AM

Can you provide more justification as to why this state needs to exist globally versus just being inside a local React component?

EDIT

This is more clear in D7343... the state needs to be set from a tooltip, which means we need some React context to hold the state. We could use a "one-off" context for this, but I think it's fine to use InputStateContainer.

inka added inline comments.Apr 11 2023, 4:07 AM

native/input/input-state.js
57 ↗	(On Diff #24781)	Couldn't this be just `+editedMessageID: ?string,` ? Do you plan to add more fields to `EditState`?

• kuba added inline comments.Apr 11 2023, 5:37 AM

native/input/input-state.js
57 ↗	(On Diff #24781)	For now, I don't plan to add new fields. But in the future, we might need more states for handling media message editing or error handling (when editing the message was unsuccessful). If it is necessary I can change it to just `editedMessageID`.