Differential D7347

[native] Preserve the draft for ChatInputBar after leaving edit mode
ClosedPublic
Actions

Authored by • kuba on Apr 7 2023, 7:22 AM.

Tags

None

Referenced Files

	F3169345: D7347.id.diff
	Thu, Nov 7, 10:51 AM

	Unknown Object (File)
	Tue, Nov 5, 2:41 AM

	Unknown Object (File)
	Tue, Nov 5, 2:41 AM

	Unknown Object (File)
	Tue, Nov 5, 2:41 AM

	Unknown Object (File)
	Sep 28 2024, 6:58 AM

	Unknown Object (File)
	Sep 28 2024, 6:58 AM

	Unknown Object (File)
	Sep 28 2024, 6:58 AM

	Unknown Object (File)
	Sep 28 2024, 6:58 AM

Subscribers

Details

Reviewers

michal
inka
ginsu

Commits

rCOMM2554b3e717db: [native] Preserve the draft for ChatInputBar after leaving edit mode

Summary

We want to preserve user input after exiting edit mode. If we are in edit mode we don't override the draft. After exiting it we want to restore the previous content. We need a callback, to always have the latest state.

Test Plan

Run the app on iOS. Typed a message in the input bar. Entered edit mode. Changed the content of the message in the input bar. Pressed cross to exit edit mode. The draft was restored correctly.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Apr 7 2023, 7:22 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 7:22 AM

• kuba added a parent revision: D7346: [native] Copy the edited message content to ChatInputBar when entering edit mode.Apr 7 2023, 7:22 AM

• kuba edited the test plan for this revision. (Show Details)

• kuba added a child revision: D7349: [native] Add alert when exiting edit mode by clicking the exit button.

Harbormaster completed remote builds in B18096: Diff 24796.Apr 7 2023, 7:45 AM

• kuba requested review of this revision.Apr 7 2023, 7:45 AM

inka accepted this revision.Apr 11 2023, 4:06 AM

This revision is now accepted and ready to land.Apr 11 2023, 4:06 AM

Hide send button, if the draft is empty

Requesting review after the changes. Now if the draft message is empty, the send button will be hidden.

Harbormaster completed remote builds in B18266: Diff 25027.Apr 12 2023, 3:38 AM

inka accepted this revision.Apr 12 2023, 5:17 AM

This revision is now accepted and ready to land.Apr 12 2023, 5:17 AM

Add callback when exiting editMode

Harbormaster completed remote builds in B18361: Diff 25155.Apr 13 2023, 11:56 PM

• kuba mentioned this in D7414: [native] Change EditState to store messageInfo instead of only id.Apr 14 2023, 6:25 AM

Closed by commit rCOMM2554b3e717db: [native] Preserve the draft for ChatInputBar after leaving edit mode (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:44 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM2554b3e717db: [native] Preserve the draft for ChatInputBar after leaving edit mode.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

13 lines

Diff 25155

native/chat/chat-input-bar.react.js

Loading...