Differential D7447

[native] Highlighting edited message
ClosedPublic
Actions

Authored by • kuba on Apr 14 2023, 1:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 1, 2:47 PM

	Unknown Object (File)
	Sat, Mar 29, 9:39 PM

	Unknown Object (File)
	Thu, Mar 27, 10:22 PM

	Unknown Object (File)
	Tue, Mar 25, 8:18 PM

	Unknown Object (File)
	Wed, Mar 19, 11:10 AM

	Unknown Object (File)
	Wed, Mar 19, 10:34 AM

	Unknown Object (File)
	Mon, Mar 17, 2:45 PM

	Unknown Object (File)
	Mon, Mar 17, 2:45 PM

Subscribers

Details

Reviewers

michal
inka
ginsu

Commits

rCOMMbae45ec161aa: [native] Highlighting edited message

Summary

We set background of the edited message to 25% of the thread color.

Test Plan

Run the app on iOS, and check if the edited message is highlighted.

Screenshots:

Screenshot 2023-04-14 at 10.40.39.png (632×742 px, 135 KB)

Screenshot 2023-04-14 at 10.41.13.png (762×714 px, 133 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Apr 14 2023, 1:28 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 14 2023, 1:28 AM

• kuba added a parent revision: D7446: [native] Discard alert when navigating in edit mode.Apr 14 2023, 1:29 AM

• kuba added a child revision: D7448: [native] Disable typeahead and media buttons in edit mode.Apr 14 2023, 1:34 AM

• kuba edited the test plan for this revision. (Show Details)Apr 14 2023, 1:41 AM

Harbormaster completed remote builds in B18364: Diff 25158.Apr 14 2023, 1:46 AM

• kuba requested review of this revision.Apr 14 2023, 1:46 AM

inka accepted this revision.Apr 18 2023, 6:46 AM

This revision is now accepted and ready to land.Apr 18 2023, 6:46 AM

Fixed issue, where highlight appeared on messages that didn't have id yet

Harbormaster completed remote builds in B18577: Diff 25453.Apr 20 2023, 3:38 AM

Closed by commit rCOMMbae45ec161aa: [native] Highlighting edited message (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:45 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMMbae45ec161aa: [native] Highlighting edited message.

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

19 lines

Diff 25158

native/chat/composed-message.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };