Page MenuHomePhabricator

[keyserver, lib] Add message search endpoint
ClosedPublic

Authored by inka on Apr 27 2023, 6:15 AM.
Tags
None
Referenced Files
F2026119: D7651.id26160.diff
Mon, Jun 17, 2:31 PM
Unknown Object (File)
Sun, Jun 16, 5:55 AM
Unknown Object (File)
Tue, Jun 11, 3:48 PM
Unknown Object (File)
Mon, Jun 10, 9:18 AM
Unknown Object (File)
Mon, Jun 10, 2:44 AM
Unknown Object (File)
Sun, Jun 9, 10:51 AM
Unknown Object (File)
Sat, Jun 8, 1:29 PM
Unknown Object (File)
Sat, Jun 8, 2:10 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3170/create-a-keyserver-endpoint-for-the-message-search-within-specific
This endpoint allows searching messages. For now we can only search in one thread. It will have to be changed a bit in the future to be able to search in many threads, but we don't yet know how we will want that to work.

Test Plan

Tested with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Apr 27 2023, 6:33 AM
ashoat added inline comments.
lib/types/message-types.js
697 ↗(On Diff #25816)

Personally I don't think we really need these aliases, we could just use SearchMessagesResponse throughout. I don't feel strongly though

This revision is now accepted and ready to land.Apr 27 2023, 12:43 PM

Remove SearchMessagesResult, rebase

Add endReached to response from message search endpoint

Fix - related messages were being counted to check if the end was reached.