Page MenuHomePhabricator

[natvie] Add SearchFooter component

Authored by inka on Wed, May 10, 3:34 AM.
Referenced Files
F570609: D7772.id26935.diff
Sat, Jun 3, 12:58 PM
Unknown Object (File)
Fri, Jun 2, 6:57 AM
Unknown Object (File)
Mon, May 29, 12:28 AM
Unknown Object (File)
Sat, May 27, 9:08 AM
Unknown Object (File)
Sat, May 27, 6:51 AM
Unknown Object (File)
Sat, May 27, 6:13 AM
Unknown Object (File)
Thu, May 25, 2:36 PM
Unknown Object (File)
Thu, May 25, 2:09 AM



On the search screen there are different messages that appear at the end of the results (like "End of results") or instead of them (like "No results, ..."). They are all styled the same, so I created a component for them

Test Plan

Displayed the coponent with some message. Checked that it looks as it should.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

inka requested review of this revision.Wed, May 10, 3:52 AM
8 ↗(On Diff #26327)

Maybe SearchFooter? Statement is very generic

19 ↗(On Diff #26327)

It's weird that these are titled emptyQuery when the component is meant to be more generic. It feels like you forgot to update the names after factoring it out

20 ↗(On Diff #26327)

When did this get added? We should be very, very critical about adding new entries to native/themes/colors.js, as it's already way too long. You should have a very good reason for doing something like this. Are you 100% sure it's absolutely necessary to add not just a new entry, but a whole new category of entries? Have you consulted Ted about this?

20 ↗(On Diff #26327)

Ah it's in D7740. I'll follow-up there

inka retitled this revision from [natvie] Add Statement component to [natvie] Add SearchFooter component.Fri, May 12, 1:40 AM
This revision is now accepted and ready to land.Wed, May 17, 3:49 AM
8 ↗(On Diff #26846)

Props should always be read-only