issue: https://linear.app/comm/issue/ENG-3842/add-the-end-of-results-and-no-results-messages
On the search screen there are different messages that appear at the end of the results (like "End of results") or instead of them (like "No results, ..."). They are all styled the same, so I created a component for them
Details
Details
- Reviewers
kuba kamil bartek - Commits
- rCOMM99ecfe2b6ea5: [natvie] Add SearchFooter component
Displayed the coponent with some message. Checked that it looks as it should.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/search/statement.react.js | ||
|---|---|---|
| 8 ↗ | (On Diff #26327) | Maybe SearchFooter? Statement is very generic |
| 19 ↗ | (On Diff #26327) | It's weird that these are titled emptyQuery when the component is meant to be more generic. It feels like you forgot to update the names after factoring it out |
| 20 ↗ | (On Diff #26327) | When did this get added? We should be very, very critical about adding new entries to native/themes/colors.js, as it's already way too long. You should have a very good reason for doing something like this. Are you 100% sure it's absolutely necessary to add not just a new entry, but a whole new category of entries? Have you consulted Ted about this? |
| 20 ↗ | (On Diff #26327) | Ah it's in D7740. I'll follow-up there |
| native/search/search-footer.react.js | ||
|---|---|---|
| 8 ↗ | (On Diff #26846) | Props should always be read-only |