Page MenuHomePhabricator

[natvie] Add SearchFooter component

Authored by inka on May 10 2023, 3:34 AM.
Referenced Files
Unknown Object (File)
Sat, Jun 15, 6:31 AM
Unknown Object (File)
Fri, Jun 14, 10:34 AM
Unknown Object (File)
Fri, Jun 14, 4:15 AM
Unknown Object (File)
Thu, Jun 13, 10:55 PM
Unknown Object (File)
Thu, Jun 13, 7:53 PM
Unknown Object (File)
Thu, Jun 13, 6:34 AM
Unknown Object (File)
Wed, Jun 12, 3:23 PM
Unknown Object (File)
Tue, Jun 11, 5:14 AM



On the search screen there are different messages that appear at the end of the results (like "End of results") or instead of them (like "No results, ..."). They are all styled the same, so I created a component for them

Test Plan

Displayed the coponent with some message. Checked that it looks as it should.

Diff Detail

rCOMM Comm
No Lint Coverage
No Test Coverage

Event Timeline

inka requested review of this revision.May 10 2023, 3:52 AM
8 ↗(On Diff #26327)

Maybe SearchFooter? Statement is very generic

19 ↗(On Diff #26327)

It's weird that these are titled emptyQuery when the component is meant to be more generic. It feels like you forgot to update the names after factoring it out

20 ↗(On Diff #26327)

When did this get added? We should be very, very critical about adding new entries to native/themes/colors.js, as it's already way too long. You should have a very good reason for doing something like this. Are you 100% sure it's absolutely necessary to add not just a new entry, but a whole new category of entries? Have you consulted Ted about this?

20 ↗(On Diff #26327)

Ah it's in D7740. I'll follow-up there

inka retitled this revision from [natvie] Add Statement component to [natvie] Add SearchFooter component.May 12 2023, 1:40 AM
This revision is now accepted and ready to land.May 17 2023, 3:49 AM

Props should always be read-only