Page MenuHomePhabricator

[natvie] Add SearchFooter component
ClosedPublic

Authored by inka on May 10 2023, 3:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 11:28 PM
Unknown Object (File)
Fri, May 24, 10:20 AM
Unknown Object (File)
Thu, May 23, 11:49 AM
Unknown Object (File)
Wed, May 22, 6:42 PM
Unknown Object (File)
Sun, May 19, 2:20 PM
Unknown Object (File)
Fri, May 17, 12:03 AM
Unknown Object (File)
Tue, May 7, 4:54 PM
Unknown Object (File)
Sun, May 5, 12:44 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3842/add-the-end-of-results-and-no-results-messages
On the search screen there are different messages that appear at the end of the results (like "End of results") or instead of them (like "No results, ..."). They are all styled the same, so I created a component for them

Test Plan

Displayed the coponent with some message. Checked that it looks as it should.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.May 10 2023, 3:52 AM
native/search/statement.react.js
8 ↗(On Diff #26327)

Maybe SearchFooter? Statement is very generic

19 ↗(On Diff #26327)

It's weird that these are titled emptyQuery when the component is meant to be more generic. It feels like you forgot to update the names after factoring it out

20 ↗(On Diff #26327)

When did this get added? We should be very, very critical about adding new entries to native/themes/colors.js, as it's already way too long. You should have a very good reason for doing something like this. Are you 100% sure it's absolutely necessary to add not just a new entry, but a whole new category of entries? Have you consulted Ted about this?

20 ↗(On Diff #26327)

Ah it's in D7740. I'll follow-up there

inka retitled this revision from [natvie] Add Statement component to [natvie] Add SearchFooter component.May 12 2023, 1:40 AM
This revision is now accepted and ready to land.May 17 2023, 3:49 AM
native/search/search-footer.react.js
8 ↗(On Diff #26846)

Props should always be read-only