issue: https://linear.app/comm/issue/ENG-3864/update-messageresult-style#comment-fe30cc85
For pinned messages and search results to be displayed correctly in the MessageResult, their data needs to be changed. I'm extracting this logic and using it ine MessageResult iteself to avoid duplicating code
Details
Details
Pinned a message, navigated to the pinned messages screen. Checked that the messages display correctly in the pinned messages screen and in the pin messages modal.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/chat/message-result.react.js | ||
|---|---|---|
| 38 ↗ | (On Diff #26324) | Why isn't this memoized? You're forcing Message to rerender on every render of MessageResult |
| 40 ↗ | (On Diff #26324) | This invariant would not be necessary if you return ChatMessageInfoItemWithHeight from modifyItemForResultScreen |
| native/chat/message-results-screen.react.js | ||
| 119 ↗ | (On Diff #26324) | Why isn't this necessary here anymore? Does MessageResultsScreen call MessageResult, and MessageResult handles it now? |
| native/chat/toggle-pin-modal.react.js | ||
| 70 ↗ | (On Diff #26324) | Does TogglePinModal call MessageResult? Wondering if this is a duplicate call, and why MessageResultsScreen doesn't need this but TogglePinModal does |
| 74 ↗ | (On Diff #26324) | This invariant would not be necessary if you return ChatMessageInfoItemWithHeight from modifyItemForResultScreen |
| native/chat/utils.js | ||
| 417 ↗ | (On Diff #26324) | You can return ChatMessageInfoItemWithHeight here |