issue: https://linear.app/comm/issue/ENG-3163/create-the-search-screen-for-message-searching
Since the query has to be passed between the search screen and the header component, that is passed in screen options, I created a context to hold the query
Details
Details
- Reviewers
• kuba kamil bartek - Commits
- rCOMM1d14e082facb: [native] Add message search context
tested with next diffs
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/search/search-provider.react.js | ||
|---|---|---|
| 2 ↗ | (On Diff #26178) | I think you should add new line here |
| 6 ↗ | (On Diff #26178) | do we consume it somewhere, so that there is a need to export? |
| 21 ↗ | (On Diff #26178) | personally, I prefer to infer the type from the default argument as for me this redundancy - but this is frequent in the codebase so as you prefer |
| native/search/search-provider.react.js | ||
|---|---|---|
| 6 ↗ | (On Diff #26178) | No, but even if we don't use it anywhere else we usually export ContexType from a file |