Page MenuHomePhabricator

[native] Add message search context
ClosedPublic

Authored by inka on May 8 2023, 4:19 AM.
Tags
None
Referenced Files
F1267860: D7739.diff
Sun, Mar 3, 4:22 AM
Unknown Object (File)
Sun, Feb 18, 5:27 AM
Unknown Object (File)
Sun, Feb 18, 4:10 AM
Unknown Object (File)
Sun, Feb 18, 3:57 AM
Unknown Object (File)
Sun, Feb 18, 3:02 AM
Unknown Object (File)
Sat, Feb 17, 9:49 PM
Unknown Object (File)
Sat, Feb 10, 5:34 AM
Unknown Object (File)
Feb 1 2024, 11:39 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3163/create-the-search-screen-for-message-searching
Since the query has to be passed between the search screen and the header component, that is passed in screen options, I created a context to hold the query

Test Plan

tested with next diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.May 8 2023, 4:35 AM
This revision is now accepted and ready to land.May 9 2023, 2:59 AM
kamil added inline comments.
native/search/search-provider.react.js
2 ↗(On Diff #26178)

I think you should add new line here

6 ↗(On Diff #26178)

do we consume it somewhere, so that there is a need to export?

21 ↗(On Diff #26178)

personally, I prefer to infer the type from the default argument as for me this redundancy - but this is frequent in the codebase so as you prefer

native/search/search-provider.react.js
6 ↗(On Diff #26178)

No, but even if we don't use it anywhere else we usually export ContexType from a file