issue: https://linear.app/comm/issue/ENG-3163/create-the-search-screen-for-message-searching
Creating a screen that will display results of message search, or "Your search results will appear here!" message
Details
Details
- Reviewers
bartek kamil • kuba ashoat - Commits
- rCOMM291efc1dd80f: [native] Add message search screen
Opened the screen, checked that it displays correctly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/search/message-search.react.js | ||
|---|---|---|
| 31–35 ↗ | (On Diff #26328) | This clears the query in the context when the screen is left |
| native/search/message-search.react.js | ||
|---|---|---|
| 1 ↗ | (On Diff #26328) | Can you use eslint-disable-next-line instead of a global eslint-disable that applies to the whole file? It's hard to tell where this is used |
| 49 ↗ | (On Diff #26328) | undefined is the default |
| 61 ↗ | (On Diff #26328) | Nit: can we remove the exclamation mark at the end? |
| 66 ↗ | (On Diff #26328) | Does return null work? If not, you could use a shorthand: return <View /> |
| 72 ↗ | (On Diff #26328) | We should avoid mixing families of colors. If we're using the panel family here, we should use that family in D7740 as well. If we choose to use a different family there, we can use something different here. If this requires changing the designs, you should consult Ted |
Comment Actions
Address revie, change the state from keeping the measured messages, to just keeping searchResults (MessageInfo) to address https://linear.app/comm/issue/ENG-3882/reaction-not-showing-in-search-screen